Fix non-noise cpplint errors in //crypto.

Fix non-noise cpplint errors in //crypto.

There are two that are wrong because cpplint gets confused about
variables named 'copy' and methods named 'swap'. Those I've left alone.

BUG=none

Review-Url: https://codereview.chromium.org/2677583002
Cr-Commit-Position: refs/heads/master@{#447926}
Committed: https://chromium.googlesource.com/chromium/src/+/6004dc581e66758dcf806ef2013408b41c3703ed

[davidben, 2017-02-02 22:49:37]

The CQ bit was checked by davidben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-02 22:50:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[davidben, 2017-02-02 22:54:32]

davidben@chromium.org changed reviewers:
+ rsleevi@chromium.org

[davidben, 2017-02-02 22:54:33]

https://codereview.chromium.org/2677583002/diff/1/crypto/ec_private_key.cc
File crypto/ec_private_key.cc (right):

https://codereview.chromium.org/2677583002/diff/1/crypto/ec_private_key.cc#ne...
crypto/ec_private_key.cc:51: if (!BIO_mem_contents(bio.get(), &data, &len))
cpplint doesn't like long, which is actually the right type of BIO_get_mem_data.
However BIO_mem_contents is a better API here anyway:

https://commondatastorage.googleapis.com/chromium-boringssl-docs/bio.h.html#B...
https://commondatastorage.googleapis.com/chromium-boringssl-docs/bio.h.html#B...

(BIO is largely unnecessary here, but I'll sort that out after we add an API for
the EncryptedPrivateKeyInfo stuff that doesn't depend on this mess.)

[Ryan Sleevi, 2017-02-02 23:22:11]

lgtm

[commit-bot: I haz the power, 2017-02-02 23:25:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-02 23:25:55]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[davidben, 2017-02-02 23:27:55]

The CQ bit was checked by davidben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-02 23:28:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[davidben, 2017-02-02 23:38:29]

The CQ bit was unchecked by davidben@chromium.org

[davidben, 2017-02-02 23:38:31]

The CQ bit was checked by davidben@chromium.org

[davidben, 2017-02-02 23:38:32]

The patchset sent to the CQ was uploaded after l-g-t-m from rsleevi@chromium.org
Link to the patchset: https://codereview.chromium.org/2677583002/#ps20001
(title: "fix p224_unittest.cc")

[commit-bot: I haz the power, 2017-02-02 23:38:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-03 04:15:36]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486078711855390,
"parent_rev": "5429b39dda87c47ace86635ab4cf998255ced5fb", "commit_rev":
"6004dc581e66758dcf806ef2013408b41c3703ed"}

[commit-bot: I haz the power, 2017-02-03 04:16:27]

Description was changed from

==========
Fix non-noise cpplint errors in //crypto.

There are two that are wrong because cpplint gets confused about
variables named 'copy' and methods named 'swap'. Those I've left alone.

BUG=none
==========

to

==========
Fix non-noise cpplint errors in //crypto.

There are two that are wrong because cpplint gets confused about
variables named 'copy' and methods named 'swap'. Those I've left alone.

BUG=none

Review-Url: https://codereview.chromium.org/2677583002
Cr-Commit-Position: refs/heads/master@{#447926}
Committed:
https://chromium.googlesource.com/chromium/src/+/6004dc581e66758dcf806ef20134...
==========

[commit-bot: I haz the power, 2017-02-03 04:16:27]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6004dc581e66758dcf806ef20134...