Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(56)

Issue 2677583002: Fix non-noise cpplint errors in //crypto. (Closed)

Created:
3 years, 11 months ago by davidben
Modified:
3 years, 11 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix non-noise cpplint errors in //crypto. There are two that are wrong because cpplint gets confused about variables named 'copy' and methods named 'swap'. Those I've left alone. BUG=none Review-Url: https://codereview.chromium.org/2677583002 Cr-Commit-Position: refs/heads/master@{#447926} Committed: https://chromium.googlesource.com/chromium/src/+/6004dc581e66758dcf806ef2013408b41c3703ed

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix p224_unittest.cc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -61 lines) Patch
M crypto/aead.h View 2 chunks +3 lines, -1 line 0 comments Download
M crypto/aead.cc View 1 chunk +1 line, -1 line 0 comments Download
M crypto/apple_keychain.h View 2 chunks +3 lines, -3 lines 0 comments Download
M crypto/ec_private_key.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M crypto/ec_signature_creator_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M crypto/encryptor.cc View 1 chunk +1 line, -1 line 0 comments Download
M crypto/encryptor_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M crypto/hmac.cc View 1 chunk +1 line, -0 lines 0 comments Download
M crypto/mock_apple_keychain.h View 2 chunks +3 lines, -3 lines 0 comments Download
M crypto/nss_crypto_module_delegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M crypto/nss_util.cc View 3 chunks +11 lines, -17 lines 0 comments Download
M crypto/nss_util_internal.h View 1 chunk +2 lines, -0 lines 0 comments Download
M crypto/openssl_util.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M crypto/p224_spake.h View 1 chunk +4 lines, -2 lines 0 comments Download
M crypto/p224_spake.cc View 3 chunks +9 lines, -6 lines 0 comments Download
M crypto/p224_unittest.cc View 1 4 chunks +7 lines, -7 lines 0 comments Download
M crypto/random.h View 1 chunk +1 line, -1 line 0 comments Download
M crypto/random_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M crypto/rsa_private_key_unittest.cc View 3 chunks +6 lines, -10 lines 0 comments Download
M crypto/scoped_test_system_nss_key_slot.h View 1 chunk +1 line, -1 line 0 comments Download
M crypto/signature_creator_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M crypto/wincrypt_shim.h View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (12 generated)
davidben
https://codereview.chromium.org/2677583002/diff/1/crypto/ec_private_key.cc File crypto/ec_private_key.cc (right): https://codereview.chromium.org/2677583002/diff/1/crypto/ec_private_key.cc#newcode51 crypto/ec_private_key.cc:51: if (!BIO_mem_contents(bio.get(), &data, &len)) cpplint doesn't like long, which ...
3 years, 11 months ago (2017-02-02 22:54:33 UTC) #4
Ryan Sleevi
lgtm
3 years, 11 months ago (2017-02-02 23:22:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2677583002/20001
3 years, 11 months ago (2017-02-02 23:38:59 UTC) #13
commit-bot: I haz the power
3 years, 11 months ago (2017-02-03 04:16:27 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6004dc581e66758dcf806ef20134...

Powered by Google App Engine
This is Rietveld 408576698