Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Side by Side Diff: crypto/random_unittest.cc

Issue 2677583002: Fix non-noise cpplint errors in //crypto. (Closed)
Patch Set: fix p224_unittest.cc Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « crypto/random.h ('k') | crypto/rsa_private_key_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "crypto/random.h" 5 #include "crypto/random.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <string>
10
9 #include "base/strings/string_util.h" 11 #include "base/strings/string_util.h"
10 #include "testing/gtest/include/gtest/gtest.h" 12 #include "testing/gtest/include/gtest/gtest.h"
11 13
12 // Basic functionality tests. Does NOT test the security of the random data. 14 // Basic functionality tests. Does NOT test the security of the random data.
13 15
14 // Ensures we don't have all trivial data, i.e. that the data is indeed random. 16 // Ensures we don't have all trivial data, i.e. that the data is indeed random.
15 // Currently, that means the bytes cannot be all the same (e.g. all zeros). 17 // Currently, that means the bytes cannot be all the same (e.g. all zeros).
16 bool IsTrivial(const std::string& bytes) { 18 bool IsTrivial(const std::string& bytes) {
17 for (size_t i = 0; i < bytes.size(); i++) { 19 for (size_t i = 0; i < bytes.size(); i++) {
18 if (bytes[i] != bytes[0]) { 20 if (bytes[i] != bytes[0]) {
19 return false; 21 return false;
20 } 22 }
21 } 23 }
22 return true; 24 return true;
23 } 25 }
24 26
25 TEST(RandBytes, RandBytes) { 27 TEST(RandBytes, RandBytes) {
26 std::string bytes(16, '\0'); 28 std::string bytes(16, '\0');
27 crypto::RandBytes(base::WriteInto(&bytes, bytes.size()), bytes.size()); 29 crypto::RandBytes(base::WriteInto(&bytes, bytes.size()), bytes.size());
28 EXPECT_TRUE(!IsTrivial(bytes)); 30 EXPECT_TRUE(!IsTrivial(bytes));
29 } 31 }
OLDNEW
« no previous file with comments | « crypto/random.h ('k') | crypto/rsa_private_key_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698