Fix non-noise cpplint errors in //crypto.

crypto/ec_private_key.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "crypto/ec_private_key.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <utility>
@@ skipping 28 matching lines @@
   if (!key)
     return false;
 
   bssl::UniquePtr<BIO> bio(BIO_new(BIO_s_mem()));
   if (!bio)
     return false;
 
   if (!export_fn(bio.get(), key))
     return false;
 
-  char* data = nullptr;
-  long len = BIO_get_mem_data(bio.get(), &data);
-  if (!data || len < 0)
+  const uint8_t* data;
+  size_t len;
+  if (!BIO_mem_contents(bio.get(), &data, &len))

[davidben, 2017/02/02 22:54:33]

cpplint doesn't like long, which is actually the right type of BIO_get_mem_data.
However BIO_mem_contents is a better API here anyway:

https://commondatastorage.googleapis.com/chromium-boringssl-docs/bio.h.html#B...
https://commondatastorage.googleapis.com/chromium-boringssl-docs/bio.h.html#B...

(BIO is largely unnecessary here, but I'll sort that out after we add an API for
the EncryptedPrivateKeyInfo stuff that doesn't depend on this mess.)

     return false;
 
   output->assign(data, data + len);
   return true;
 }
 
 }  // namespace
 
 ECPrivateKey::~ECPrivateKey() {}
 
@@ skipping 153 matching lines @@
     return false;
   }
 
   output->assign(reinterpret_cast<const char*>(buf), sizeof(buf));
   return true;
 }
 
 ECPrivateKey::ECPrivateKey() {}
 
 }  // namespace crypto