[ic] Encode [Keyed]StoreIC's language mode in slot kind instead of code object's flags.

[ic] Encode [Keyed]StoreIC's language mode in slot kind instead of code object's flags.

BUG=v8:5917
Review-Url: https://codereview.chromium.org/2676583002
Cr-Commit-Position: refs/heads/master@{#42949}
Committed: https://chromium.googlesource.com/v8/v8/+/52555c86b7b2d238d0883067ae866df3de49b9cd

[Igor Sheludko, 2017-02-02 11:52:04]

Patchset #1 (id:1) has been deleted

[Igor Sheludko, 2017-02-02 11:52:19]

ishell@chromium.org changed reviewers:
+ mvstanton@chromium.org

[Igor Sheludko, 2017-02-02 11:52:20]

PTAL

[Igor Sheludko, 2017-02-02 11:53:16]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-02 11:53:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Benedikt Meurer, 2017-02-02 11:54:59]

bmeurer@chromium.org changed reviewers:
+ bmeurer@chromium.org

[Benedikt Meurer, 2017-02-02 11:55:00]

LGTM.

[commit-bot: I haz the power, 2017-02-02 12:03:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-02 12:03:21]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)

[Igor Sheludko, 2017-02-02 12:08:51]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-02 12:09:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Michael Starzinger, 2017-02-02 12:26:21]

mstarzinger@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[Michael Starzinger, 2017-02-02 12:26:21]

mstarzinger@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[Michael Starzinger, 2017-02-02 12:26:21]

LGTM on heap changes. Didn't look at the rest.

[Michael Starzinger, 2017-02-02 12:26:22]

LGTM on heap changes. Didn't look at the rest.

[commit-bot: I haz the power, 2017-02-02 12:41:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-02 12:41:54]

Dry run: Try jobs failed on following builders:
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/20335)
  v8_linux64_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng_triggered...)

[Igor Sheludko, 2017-02-02 17:04:11]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-02 17:04:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-02 17:05:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-02 17:05:50]

Dry run: Try jobs failed on following builders:
  v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...)
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/20355)
  v8_linux64_verify_csa_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_verify_csa_rel_n...)
  v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...)
  v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/20425)
  v8_linux_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/20315)

[Igor Sheludko, 2017-02-03 15:35:36]

Patchset #5 (id:100001) has been deleted

[Igor Sheludko, 2017-02-03 15:42:27]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-03 15:42:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Igor Sheludko, 2017-02-03 16:12:44]

This CL is ready for review again. PTAL

[commit-bot: I haz the power, 2017-02-03 16:13:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-03 16:13:22]

Dry run: This issue passed the CQ dry run.

[mvstanton, 2017-02-06 08:23:51]

LGTM

https://codereview.chromium.org/2676583002/diff/120001/src/compiler/bytecode-...
File src/compiler/bytecode-graph-builder.cc (right):

https://codereview.chromium.org/2676583002/diff/120001/src/compiler/bytecode-...
src/compiler/bytecode-graph-builder.cc:1032:
DCHECK_EQ(feedback.vector()->GetLanguageMode(feedback.slot()), language_mode);
Nice assert to add, thx!

[Igor Sheludko, 2017-02-06 08:55:31]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-06 08:55:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-06 09:25:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-06 09:25:51]

Dry run: This issue passed the CQ dry run.

[Michael Starzinger, 2017-02-06 09:28:52]

LGTM on interpreter as well, didn't look at the rest.

[Igor Sheludko, 2017-02-06 09:29:43]

The CQ bit was checked by ishell@chromium.org

[Igor Sheludko, 2017-02-06 09:29:43]

The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/2676583002/#ps120001
(title: "Rebasing")

[commit-bot: I haz the power, 2017-02-06 09:29:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-06 09:31:53]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1486373383294790,
"parent_rev": "c737982c90a6ae22e87214ac0751df6728b91942", "commit_rev":
"52555c86b7b2d238d0883067ae866df3de49b9cd"}

[commit-bot: I haz the power, 2017-02-06 09:31:57]

Description was changed from

==========
[ic] Encode [Keyed]StoreIC's language mode in slot kind instead of code object's
flags.

BUG=v8:5917
==========

to

==========
[ic] Encode [Keyed]StoreIC's language mode in slot kind instead of code object's
flags.

BUG=v8:5917

Review-Url: https://codereview.chromium.org/2676583002
Cr-Commit-Position: refs/heads/master@{#42949}
Committed:
https://chromium.googlesource.com/v8/v8/+/52555c86b7b2d238d0883067ae866df3de4...
==========

[commit-bot: I haz the power, 2017-02-06 09:32:01]

Committed patchset #5 (id:120001) as
https://chromium.googlesource.com/v8/v8/+/52555c86b7b2d238d0883067ae866df3de4...