src/compiler/js-native-context-specialization.cc - Issue 2676583002: [ic] Encode [Keyed]StoreIC's language mode in slot kind instead of code object's flags.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/js-native-context-specialization.cc

Issue 2676583002: [ic] Encode [Keyed]StoreIC's language mode in slot kind instead of code object's flags. (Closed)

Patch Set: Rebasing Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/js-native-context-specialization.cc

diff --git a/src/compiler/js-native-context-specialization.cc b/src/compiler/js-native-context-specialization.cc

index 4d87638b31838d951fbf6838499644638b843d9e..8b18cbae492b80549ab879f67a7d38e1446664b4 100644

--- a/src/compiler/js-native-context-specialization.cc

+++ b/src/compiler/js-native-context-specialization.cc

@@ -1547,6 +1547,7 @@ JSNativeContextSpecialization::BuildPropertyAccess(

DCHECK(access_info.IsGeneric());

DCHECK_EQ(AccessMode::kStore, access_mode);

DCHECK(vector->IsStoreIC(slot));

+ DCHECK_EQ(vector->GetLanguageMode(slot), language_mode);

Callable callable =

CodeFactory::StoreICInOptimizedCode(isolate(), language_mode);

const CallInterfaceDescriptor& descriptor = callable.descriptor();