Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Unified Diff: src/type-feedback-vector-inl.h

Issue 2676583002: [ic] Encode [Keyed]StoreIC's language mode in slot kind instead of code object's flags. (Closed)
Patch Set: Rebasing Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/type-feedback-vector-inl.h
diff --git a/src/type-feedback-vector-inl.h b/src/type-feedback-vector-inl.h
index 31f78210020b4512bedb73e14d997ada157810b0..43f055b7bd6f8af19a4b67e6fc9bc1eabb856b62 100644
--- a/src/type-feedback-vector-inl.h
+++ b/src/type-feedback-vector-inl.h
@@ -63,8 +63,10 @@ int TypeFeedbackMetadata::GetSlotSize(FeedbackVectorSlotKind kind) {
case FeedbackVectorSlotKind::LOAD_IC:
case FeedbackVectorSlotKind::LOAD_GLOBAL_IC:
case FeedbackVectorSlotKind::KEYED_LOAD_IC:
- case FeedbackVectorSlotKind::STORE_IC:
- case FeedbackVectorSlotKind::KEYED_STORE_IC:
+ case FeedbackVectorSlotKind::STORE_SLOPPY_IC:
+ case FeedbackVectorSlotKind::STORE_STRICT_IC:
+ case FeedbackVectorSlotKind::KEYED_STORE_SLOPPY_IC:
+ case FeedbackVectorSlotKind::KEYED_STORE_STRICT_IC:
case FeedbackVectorSlotKind::STORE_DATA_PROPERTY_IN_LITERAL_IC:
return 2;
@@ -174,8 +176,10 @@ void TypeFeedbackVector::ComputeCounts(int* with_type_info, int* generic,
case FeedbackVectorSlotKind::LOAD_IC:
case FeedbackVectorSlotKind::LOAD_GLOBAL_IC:
case FeedbackVectorSlotKind::KEYED_LOAD_IC:
- case FeedbackVectorSlotKind::STORE_IC:
- case FeedbackVectorSlotKind::KEYED_STORE_IC:
+ case FeedbackVectorSlotKind::STORE_SLOPPY_IC:
+ case FeedbackVectorSlotKind::STORE_STRICT_IC:
+ case FeedbackVectorSlotKind::KEYED_STORE_SLOPPY_IC:
+ case FeedbackVectorSlotKind::KEYED_STORE_STRICT_IC:
case FeedbackVectorSlotKind::STORE_DATA_PROPERTY_IN_LITERAL_IC: {
if (obj->IsWeakCell() || obj->IsFixedArray() || obj->IsString()) {
with++;

Powered by Google App Engine
This is Rietveld 408576698