Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(669)

Issue 2670863003: [stubs] Port KeyedStoreIC_Slow/Miss and StoreSlowElementStub to TF. (Closed)

Created:
3 years, 10 months ago by Igor Sheludko
Modified:
3 years, 10 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[stubs] Port KeyedStoreIC_Slow/Miss and StoreSlowElementStub to TF. This CL also removes unused LoadApiGetterStub and renames StoreElementStub to StoreSlowElementStub. BUG=v8:4587 Review-Url: https://codereview.chromium.org/2670863003 Cr-Commit-Position: refs/heads/master@{#42951} Committed: https://chromium.googlesource.com/v8/v8/+/979009041e188c93782401986c661c7309a156be

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -389 lines) Patch
M src/builtins/builtins.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/builtins/builtins-handler.cc View 1 chunk +26 lines, -4 lines 0 comments Download
M src/code-stubs.h View 4 chunks +6 lines, -46 lines 0 comments Download
M src/code-stubs.cc View 2 chunks +13 lines, -20 lines 0 comments Download
M src/ic/arm/ic-arm.cc View 1 chunk +0 lines, -32 lines 0 comments Download
M src/ic/arm64/ic-arm64.cc View 1 chunk +0 lines, -26 lines 0 comments Download
M src/ic/ia32/ic-ia32.cc View 1 chunk +0 lines, -42 lines 0 comments Download
M src/ic/ic.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/ic/ic-compiler.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/ic/mips/ic-mips.cc View 1 chunk +0 lines, -32 lines 0 comments Download
M src/ic/mips64/ic-mips64.cc View 1 chunk +0 lines, -32 lines 0 comments Download
M src/ic/ppc/ic-ppc.cc View 1 chunk +0 lines, -32 lines 0 comments Download
M src/ic/s390/ic-s390.cc View 1 chunk +0 lines, -29 lines 0 comments Download
M src/ic/x64/ic-x64.cc View 1 chunk +0 lines, -42 lines 0 comments Download
M src/ic/x87/ic-x87.cc View 1 chunk +0 lines, -42 lines 0 comments Download
M src/type-feedback-vector.cc View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 26 (22 generated)
Igor Sheludko
PTAL
3 years, 10 months ago (2017-02-03 16:30:08 UTC) #14
Jakob Kummerow
LGTM, nice!
3 years, 10 months ago (2017-02-03 19:51:26 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2670863003/60001
3 years, 10 months ago (2017-02-06 10:03:20 UTC) #23
commit-bot: I haz the power
3 years, 10 months ago (2017-02-06 10:05:04 UTC) #26
Message was sent while issue was closed.
Committed patchset #1 (id:60001) as
https://chromium.googlesource.com/v8/v8/+/979009041e188c93782401986c661c7309a...

Powered by Google App Engine
This is Rietveld 408576698