Generate nonproperty 'variableReference' in ComputedStyleBase.

Generate nonproperty 'variableReference' in ComputedStyleBase.

Move the nonproperty field 'variableReference' to be generated in
ComputedStyleBase. Also moved getter / setter methods to be generated in
ComputedStyleBase.

Note that this renames m_variableReference to something much longer.
This shouldn't affect anything since the member is private and only used
within the generated class.

BUG=628043
Review-Url: https://codereview.chromium.org/2676513002
Cr-Commit-Position: refs/heads/master@{#454271}
Committed: https://chromium.googlesource.com/chromium/src/+/37a76369eb0ad7176c613023f29a16fde58f8b97

[shend, 2017-02-02 04:59:23]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-02 04:59:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[shend, 2017-02-02 05:00:06]

shend@chromium.org changed reviewers:
+ nainar@chromium.org

[shend, 2017-02-02 05:00:06]

Hi Naina, just two more of these PTAL :)

[nainar, 2017-02-02 05:03:06]

lgtm

[shend, 2017-02-02 05:04:49]

shend@chromium.org changed reviewers:
+ sashab@chromium.org

[shend, 2017-02-02 05:04:49]

Hi Sasha PTAL

[commit-bot: I haz the power, 2017-02-02 06:45:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-02 06:45:25]

Dry run: This issue passed the CQ dry run.

[sashab, 2017-02-03 05:06:40]

There is one more caller of setHasVariableReferenceFromNonInheritedProperty, in
StyleBuilder.cpp.tmpl I believe

[shend, 2017-02-03 05:34:50]

On 2017/02/03 at 05:06:40, sashab wrote:
> There is one more caller of setHasVariableReferenceFromNonInheritedProperty,
in StyleBuilder.cpp.tmpl I believe

Yeah see the comment in https://codereview.chromium.org/2672703002 , I'm not
quite sure what you mean.

[shend, 2017-03-01 15:35:55]

Hi Sasha, since we're not doing the rename anymore, PTAL again?

[sashab, 2017-03-01 22:56:33]

Too easy, lgtm

[shend, 2017-03-02 02:26:48]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-02 02:27:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-02 04:53:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-02 04:53:34]

Dry run: This issue passed the CQ dry run.

[shend, 2017-03-02 15:56:37]

The CQ bit was checked by shend@chromium.org

[shend, 2017-03-02 15:56:38]

The patchset sent to the CQ was uploaded after l-g-t-m from nainar@chromium.org,
sashab@chromium.org
Link to the patchset: https://codereview.chromium.org/2676513002/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2017-03-02 15:56:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-02 16:00:27]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1488470197381230,
"parent_rev": "f22f70a9ea38fd490fbf809660566cae77538b90", "commit_rev":
"37a76369eb0ad7176c613023f29a16fde58f8b97"}

[commit-bot: I haz the power, 2017-03-02 16:01:06]

Description was changed from

==========
Generate nonproperty 'variableReference' in ComputedStyleBase.

Move the nonproperty field 'variableReference' to be generated in
ComputedStyleBase. Also moved getter / setter methods to be generated in
ComputedStyleBase.

Note that this renames m_variableReference to something much longer.
This shouldn't affect anything since the member is private and only used
within the generated class.

BUG=628043
==========

to

==========
Generate nonproperty 'variableReference' in ComputedStyleBase.

Move the nonproperty field 'variableReference' to be generated in
ComputedStyleBase. Also moved getter / setter methods to be generated in
ComputedStyleBase.

Note that this renames m_variableReference to something much longer.
This shouldn't affect anything since the member is private and only used
within the generated class.

BUG=628043

Review-Url: https://codereview.chromium.org/2676513002
Cr-Commit-Position: refs/heads/master@{#454271}
Committed:
https://chromium.googlesource.com/chromium/src/+/37a76369eb0ad7176c613023f29a...
==========

[commit-bot: I haz the power, 2017-03-02 16:01:08]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/37a76369eb0ad7176c613023f29a...