Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Side by Side Diff: third_party/WebKit/Source/core/style/ComputedStyle.cpp

Issue 2676513002: Generate nonproperty 'variableReference' in ComputedStyleBase. (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/core/style/ComputedStyle.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Antti Koivisto (koivisto@kde.org) 2 * Copyright (C) 1999 Antti Koivisto (koivisto@kde.org)
3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights 3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights
4 * reserved. 4 * reserved.
5 * Copyright (C) 2011 Adobe Systems Incorporated. All rights reserved. 5 * Copyright (C) 2011 Adobe Systems Incorporated. All rights reserved.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 374 matching lines...) Expand 10 before | Expand all | Expand 10 after
385 // m_nonInheritedData.m_pseudoBits 385 // m_nonInheritedData.m_pseudoBits
386 386
387 // Set correctly while computing style for children: 387 // Set correctly while computing style for children:
388 // m_nonInheritedData.m_explicitInheritance 388 // m_nonInheritedData.m_explicitInheritance
389 389
390 // unique() styles are not cacheable. 390 // unique() styles are not cacheable.
391 DCHECK(!other.unique()); 391 DCHECK(!other.unique());
392 392
393 // styles with non inherited properties that reference variables are not 393 // styles with non inherited properties that reference variables are not
394 // cacheable. 394 // cacheable.
395 DCHECK(!other.m_nonInheritedData.m_variableReference); 395 DCHECK(!other.hasVariableReferenceFromNonInheritedProperty());
396 396
397 // The following flags are set during matching before we decide that we get a 397 // The following flags are set during matching before we decide that we get a
398 // match in the MatchedPropertiesCache which in turn calls this method. The 398 // match in the MatchedPropertiesCache which in turn calls this method. The
399 // reason why we don't copy these flags is that they're already correctly set 399 // reason why we don't copy these flags is that they're already correctly set
400 // and that they may differ between elements which have the same set of 400 // and that they may differ between elements which have the same set of
401 // matched properties. For instance, given the rule: 401 // matched properties. For instance, given the rule:
402 // 402 //
403 // :-webkit-any(:hover, :focus) { background-color: green }" 403 // :-webkit-any(:hover, :focus) { background-color: green }"
404 // 404 //
405 // A hovered element, and a focused element may use the same cached matched 405 // A hovered element, and a focused element may use the same cached matched
(...skipping 2092 matching lines...) Expand 10 before | Expand all | Expand 10 after
2498 if (value < 0) 2498 if (value < 0)
2499 fvalue -= 0.5f; 2499 fvalue -= 0.5f;
2500 else 2500 else
2501 fvalue += 0.5f; 2501 fvalue += 0.5f;
2502 } 2502 }
2503 2503
2504 return roundForImpreciseConversion<int>(fvalue / zoomFactor); 2504 return roundForImpreciseConversion<int>(fvalue / zoomFactor);
2505 } 2505 }
2506 2506
2507 } // namespace blink 2507 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/style/ComputedStyle.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698