Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Issue 2672703002: Generate nonproperty 'explicitInheritance' in ComputedStyleBase. (Closed)

Created:
3 years, 10 months ago by shend
Modified:
3 years, 9 months ago
Reviewers:
nainar, sashab
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Generate nonproperty 'explicitInheritance' in ComputedStyleBase. Move the nonproperty field 'explicitInheritance' to be generated in ComputedStyleBase. Also moved getter / setter methods to be generated in ComputedStyleBase. Note that this renames m_explicitInheritance to something much longer. This shouldn't affect anything since the member is private and only used within the generated class. Also, after this patch, ComputedStyle returns to its original size. BUG=628043 Review-Url: https://codereview.chromium.org/2672703002 Cr-Commit-Position: refs/heads/master@{#454520} Committed: https://chromium.googlesource.com/chromium/src/+/c26572689b73d3ecee94cd96257f4822d6e21950

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Size check #

Patch Set 4 : Size check #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -11 lines) Patch
M third_party/WebKit/Source/build/scripts/make_computed_style_base.py View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 2 3 3 chunks +0 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 36 (24 generated)
shend
Hi Naina, PTAL
3 years, 10 months ago (2017-02-02 05:00:33 UTC) #4
nainar
lgtm
3 years, 10 months ago (2017-02-02 05:03:08 UTC) #5
shend
Hi Sasha, PTAL
3 years, 10 months ago (2017-02-02 05:04:32 UTC) #7
sashab
Need to update StyleBuilder call to setHasExplicitlyInheritedProperties
3 years, 10 months ago (2017-02-03 05:08:15 UTC) #10
sashab
Also in CL desc: 'something much longer' -> 'm_fejfesfjsefljef, which is much longer'
3 years, 10 months ago (2017-02-03 05:08:34 UTC) #11
shend
On 2017/02/03 at 05:08:34, sashab wrote: > Also in CL desc: 'something much longer' -> ...
3 years, 10 months ago (2017-02-03 05:29:31 UTC) #12
shend
On 2017/02/03 at 05:08:15, sashab wrote: > Need to update StyleBuilder call to setHasExplicitlyInheritedProperties Hmm, ...
3 years, 10 months ago (2017-02-03 05:33:12 UTC) #13
sashab
Ohh sorry sorry. I may have done these reviews while half-asleep... Gonna pause reviewing these ...
3 years, 10 months ago (2017-02-03 20:11:16 UTC) #14
shend
Hi Sasha, since we're not doing the rename anymore, PTAL again?
3 years, 9 months ago (2017-03-01 15:35:27 UTC) #15
sashab
LGTM, this will conflict with your variable reference one in the py file I'd make ...
3 years, 9 months ago (2017-03-01 22:58:34 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2672703002/60001
3 years, 9 months ago (2017-03-03 05:33:59 UTC) #33
commit-bot: I haz the power
3 years, 9 months ago (2017-03-03 05:40:41 UTC) #36
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/c26572689b73d3ecee94cd96257f...

Powered by Google App Engine
This is Rietveld 408576698