Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(956)

Issue 2725853003: Remove non-generated member 'm_unique' from ComputedStyle. (Closed)

Created:
3 years, 9 months ago by shend
Modified:
3 years, 9 months ago
Reviewers:
sashab
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove non-generated member 'm_unique' from ComputedStyle. In a previous patch (crrev.com/2667543002), the nonproperty 'unique' became generated in ComputedStyleBase. However, the original handwritten 'unique' was not removed from ComputedStyle, so we currently have two declarations of 'unique', one of which is not used. This patch removes the handwritten version which is unused. BUG=628043 Review-Url: https://codereview.chromium.org/2725853003 Cr-Commit-Position: refs/heads/master@{#454269} Committed: https://chromium.googlesource.com/chromium/src/+/600391d1b460f14000ea7035144f1d5d3460a9a5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M third_party/WebKit/Source/core/style/ComputedStyle.h View 2 chunks +0 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 16 (8 generated)
shend
Hi Sasha, PTAL :P
3 years, 9 months ago (2017-03-02 02:14:46 UTC) #2
sashab
LGTM ;P
3 years, 9 months ago (2017-03-02 02:15:38 UTC) #3
sashab
On 2017/03/02 at 02:15:38, sashab wrote: > LGTM ;P Follow-up patch: can we move the ...
3 years, 9 months ago (2017-03-02 02:16:10 UTC) #4
sashab
3 years, 9 months ago (2017-03-02 02:16:13 UTC) #5
shend
On 2017/03/02 at 02:16:10, sashab wrote: > On 2017/03/02 at 02:15:38, sashab wrote: > > ...
3 years, 9 months ago (2017-03-02 02:26:30 UTC) #6
sashab
So it is too! https://cs.chromium.org/chromium/src/third_party/WebKit/Source/build/scripts/make_computed_style_base.py?q=make_computed_style_base.py&sq=package:chromium&dr Thanks Darren - awesome work (Y)
3 years, 9 months ago (2017-03-02 02:27:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2725853003/1
3 years, 9 months ago (2017-03-02 15:38:28 UTC) #13
commit-bot: I haz the power
3 years, 9 months ago (2017-03-02 15:43:06 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/600391d1b460f14000ea7035144f...

Powered by Google App Engine
This is Rietveld 408576698