milo: Use struct for BuildBot properties.

milo: Use struct for BuildBot properties.

Use a struct for BuildBot properties internally. This will
Marshal/Unmarshal to the previous []interface{} construction, but
internally it will make the properties more accessible.

BUG=chromium:687625
TEST=unit

Review-Url: https://codereview.chromium.org/2676503002
Committed: https://github.com/luci/luci-go/commit/96163a8561d90a9784ae79e12683d7440a457f04

[dnj, 2017-02-02 02:57:26]

dnj@chromium.org changed reviewers:
+ hinoka@chromium.org

[dnj, 2017-02-02 02:57:27]

PTAL. This set of CLs adds a pRPC service to Milo called "BuildInfo". This
service offers a one-stop shop for users to query Milo about a specific build,
referencing it using familiar terms, and receive canonical build data (mostly
LogDog annotation protobufs) and metadata. It is envisioned as an entry point
for services that wish to learn about builds or view their logs.

CL chain:
https://codereview.chromium.org/2671633002 - (prep) Export host in LogDog
client.
https://codereview.chromium.org/2674603002 - (prep) Milo logdog module exports
AnnotationStream loading.
https://codereview.chromium.org/2675493003 - (prep) Refactor Swarming a bit, add
parallel fetcher.
https://codereview.chromium.org/2667353002 - Barebones (Unimplemented) BuildInfo
service addition.
https://codereview.chromium.org/2676503002 - (prep) Use strict for BuildBot
properties instead of []interface{}
https://codereview.chromium.org/2674513003 - BuildInfo implementation for
BuildBot builds.
https://codereview.chromium.org/2667363002 - BuildInfo implementation for
Swarming Kitchen builds.

[hinoka, 2017-02-03 01:06:17]

lgtm

https://codereview.chromium.org/2676503002/diff/1/milo/appengine/buildbot/str...
File milo/appengine/buildbot/structs.go (right):

https://codereview.chromium.org/2676503002/diff/1/milo/appengine/buildbot/str...
milo/appengine/buildbot/structs.go:81: return json.Marshal([]interface{}{p.Name,
p.Value, p.Source})
This works??? I am amazed and terrified at the same time.

[dnj, 2017-02-03 01:30:00]

https://codereview.chromium.org/2676503002/diff/1/milo/appengine/buildbot/str...
File milo/appengine/buildbot/structs.go (right):

https://codereview.chromium.org/2676503002/diff/1/milo/appengine/buildbot/str...
milo/appengine/buildbot/structs.go:81: return json.Marshal([]interface{}{p.Name,
p.Value, p.Source})
On 2017/02/03 01:06:17, hinoka wrote:
> This works??? I am amazed and terrified at the same time.

Yep, Marshal will just see it as it was prior to this CL: a slice of interface{}
things.

[dnj, 2017-02-03 23:45:58]

The CQ bit was checked by dnj@chromium.org

[commit-bot: I haz the power, 2017-02-03 23:46:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-03 23:51:39]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1486165558043030, "parent_rev":
"92c12a344d7dc408cc9589f195590fb5ce1edd64", "commit_rev":
"96163a8561d90a9784ae79e12683d7440a457f04"}

[commit-bot: I haz the power, 2017-02-03 23:51:42]

Description was changed from

==========
milo: Use struct for BuildBot properties.

Use a struct for BuildBot properties internally. This will
Marshal/Unmarshal to the previous []interface{} construction, but
internally it will make the properties more accessible.

BUG=chromium:687625
TEST=unit
==========

to

==========
milo: Use struct for BuildBot properties.

Use a struct for BuildBot properties internally. This will
Marshal/Unmarshal to the previous []interface{} construction, but
internally it will make the properties more accessible.

BUG=chromium:687625
TEST=unit

Review-Url: https://codereview.chromium.org/2676503002
Committed:
https://github.com/luci/luci-go/commit/96163a8561d90a9784ae79e12683d7440a457f04
==========

[commit-bot: I haz the power, 2017-02-03 23:51:43]

Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/96163a8561d90a9784ae79e12683d7440a457f04