milo: Add barebones BuildInfo pRPC service.

milo: Add barebones BuildInfo pRPC service.

BUG=chromium:687625
TEST=None

Review-Url: https://codereview.chromium.org/2667353002
Committed: https://github.com/luci/luci-go/commit/92c12a344d7dc408cc9589f195590fb5ce1edd64

[dnj, 2017-02-02 02:57:20]

dnj@chromium.org changed reviewers:
+ hinoka@chromium.org

[dnj, 2017-02-02 02:57:21]

PTAL. This set of CLs adds a pRPC service to Milo called "BuildInfo". This
service offers a one-stop shop for users to query Milo about a specific build,
referencing it using familiar terms, and receive canonical build data (mostly
LogDog annotation protobufs) and metadata. It is envisioned as an entry point
for services that wish to learn about builds or view their logs.

CL chain:
https://codereview.chromium.org/2671633002 - (prep) Export host in LogDog
client.
https://codereview.chromium.org/2674603002 - (prep) Milo logdog module exports
AnnotationStream loading.
https://codereview.chromium.org/2675493003 - (prep) Refactor Swarming a bit, add
parallel fetcher.
https://codereview.chromium.org/2667353002 - Barebones (Unimplemented) BuildInfo
service addition.
https://codereview.chromium.org/2676503002 - (prep) Use strict for BuildBot
properties instead of []interface{}
https://codereview.chromium.org/2674513003 - BuildInfo implementation for
BuildBot builds.
https://codereview.chromium.org/2667363002 - BuildInfo implementation for
Swarming Kitchen builds.

[hinoka, 2017-02-02 22:46:23]

lgtm

I can forsee also a "buildbucket" request, which does an extra hop via
buildbucket to figure out what the swarming taskID is.

https://codereview.chromium.org/2667353002/diff/1/milo/api/proto/buildinfo.proto
File milo/api/proto/buildinfo.proto (right):

https://codereview.chromium.org/2667353002/diff/1/milo/api/proto/buildinfo.pr...
milo/api/proto/buildinfo.proto:11: // The buildbot service definition.
BuildInfo?  Also copypasta the description you sent out in your codreview email
message, I think that was helpful.

https://codereview.chromium.org/2667353002/diff/1/milo/api/proto/buildinfo.pr...
milo/api/proto/buildinfo.proto:30: string task = 1;
string server = 1.  we have like 8 of them.

https://codereview.chromium.org/2667353002/diff/1/milo/api/proto/buildinfo.pr...
milo/api/proto/buildinfo.proto:45: string project_hint = 11;
Is this actively useful in V1? If not let's remove it until we need it.  It's
always easier to add fields than remove them.

https://codereview.chromium.org/2667353002/diff/1/milo/appengine/buildinfo/se...
File milo/appengine/buildinfo/service.go (right):

https://codereview.chromium.org/2667353002/diff/1/milo/appengine/buildinfo/se...
milo/appengine/buildinfo/service.go:27: return nil,
grpcutil.Errf(codes.InvalidArgument, "invalid project hint: %s", err.Error())
Available hints include: <add all hints>

[dnj, 2017-02-03 01:53:26]

https://codereview.chromium.org/2667353002/diff/1/milo/api/proto/buildinfo.proto
File milo/api/proto/buildinfo.proto (right):

https://codereview.chromium.org/2667353002/diff/1/milo/api/proto/buildinfo.pr...
milo/api/proto/buildinfo.proto:11: // The buildbot service definition.
On 2017/02/02 22:46:23, hinoka wrote:
> BuildInfo?  Also copypasta the description you sent out in your codreview
email
> message, I think that was helpful.

OK

https://codereview.chromium.org/2667353002/diff/1/milo/api/proto/buildinfo.pr...
milo/api/proto/buildinfo.proto:30: string task = 1;
On 2017/02/02 22:46:23, hinoka wrote:
> string server = 1.  we have like 8 of them.

ATM I'm leaving server off until we have a whitelist of allowed servers (RE
vulnerability). I'll do that next, then add it as an = 2.

https://codereview.chromium.org/2667353002/diff/1/milo/api/proto/buildinfo.pr...
milo/api/proto/buildinfo.proto:45: string project_hint = 11;
On 2017/02/02 22:46:23, hinoka wrote:
> Is this actively useful in V1? If not let's remove it until we need it.  It's
> always easier to add fields than remove them.

Yes, it is. Older builds especially, which don't have that property, can use
this.

https://codereview.chromium.org/2667353002/diff/1/milo/appengine/buildinfo/se...
File milo/appengine/buildinfo/service.go (right):

https://codereview.chromium.org/2667353002/diff/1/milo/appengine/buildinfo/se...
milo/appengine/buildinfo/service.go:27: return nil,
grpcutil.Errf(codes.InvalidArgument, "invalid project hint: %s", err.Error())
On 2017/02/02 22:46:23, hinoka wrote:
> Available hints include: <add all hints>

! Can't list all projects here yet. Maybe can later once we move Milo to using
datastore-backed config and can issue as-user queries. Otherwise, there are both
leak (show internal projects to public users) and performance (the query is
expensive) problems.

[dnj, 2017-02-03 01:54:25]

https://codereview.chromium.org/2667353002/diff/1/milo/appengine/buildinfo/se...
File milo/appengine/buildinfo/service.go (right):

https://codereview.chromium.org/2667353002/diff/1/milo/appengine/buildinfo/se...
milo/appengine/buildinfo/service.go:27: return nil,
grpcutil.Errf(codes.InvalidArgument, "invalid project hint: %s", err.Error())
On 2017/02/03 01:53:26, dnj wrote:
> On 2017/02/02 22:46:23, hinoka wrote:
> > Available hints include: <add all hints>
> 
> ! Can't list all projects here yet. Maybe can later once we move Milo to using
> datastore-backed config and can issue as-user queries. Otherwise, there are
both
> leak (show internal projects to public users) and performance (the query is
> expensive) problems.

Oh also, this implies a malformed project name, not a non-existent one.

[dnj, 2017-02-03 22:20:22]

The CQ bit was checked by dnj@chromium.org

[dnj, 2017-02-03 22:20:22]

The patchset sent to the CQ was uploaded after l-g-t-m from hinoka@chromium.org
Link to the patchset: https://codereview.chromium.org/2667353002/#ps60001
(title: "Swap order, users first.")

[commit-bot: I haz the power, 2017-02-03 22:20:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-03 22:27:26]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1486160422391160,
"parent_rev": "f640dfb81c083686c36758c43176f983c9351d38", "commit_rev":
"92c12a344d7dc408cc9589f195590fb5ce1edd64"}

[commit-bot: I haz the power, 2017-02-03 22:27:30]

Description was changed from

==========
milo: Add barebones BuildInfo pRPC service.

BUG=chromium:687625
TEST=None
==========

to

==========
milo: Add barebones BuildInfo pRPC service.

BUG=chromium:687625
TEST=None

Review-Url: https://codereview.chromium.org/2667353002
Committed:
https://github.com/luci/luci-go/commit/92c12a344d7dc408cc9589f195590fb5ce1edd64
==========

[commit-bot: I haz the power, 2017-02-03 22:27:31]

Committed patchset #4 (id:60001) as
https://github.com/luci/luci-go/commit/92c12a344d7dc408cc9589f195590fb5ce1edd64