milo: Add a build info Swarming implementation.

milo: Add a build info Swarming implementation.

Add a BuildInfo implementation for Swarming builds. This currently only
handles Kitchen-initiated builds, since they're the only ones whose
annotation stream path we understand.

BUG=chromium:687625
TEST=unit

Review-Url: https://codereview.chromium.org/2667363002
Committed: https://github.com/luci/luci-go/commit/64c2ca4b695d4427907ee8325515589ecbbae026

[dnj, 2017-02-02 02:57:40]

dnj@chromium.org changed reviewers:
+ hinoka@chromium.org

[dnj, 2017-02-02 02:57:41]

PTAL. This set of CLs adds a pRPC service to Milo called "BuildInfo". This
service offers a one-stop shop for users to query Milo about a specific build,
referencing it using familiar terms, and receive canonical build data (mostly
LogDog annotation protobufs) and metadata. It is envisioned as an entry point
for services that wish to learn about builds or view their logs.

CL chain:
https://codereview.chromium.org/2671633002 - (prep) Export host in LogDog
client.
https://codereview.chromium.org/2674603002 - (prep) Milo logdog module exports
AnnotationStream loading.
https://codereview.chromium.org/2675493003 - (prep) Refactor Swarming a bit, add
parallel fetcher.
https://codereview.chromium.org/2667353002 - Barebones (Unimplemented) BuildInfo
service addition.
https://codereview.chromium.org/2676503002 - (prep) Use strict for BuildBot
properties instead of []interface{}
https://codereview.chromium.org/2674513003 - BuildInfo implementation for
BuildBot builds.
https://codereview.chromium.org/2667363002 - BuildInfo implementation for
Swarming Kitchen builds.

[dnj, 2017-02-02 02:57:53]

Description was changed from

==========
milo: Add a build info Swarming implementation.

Add a BuildInfo implementation for Swarming builds. This currently only
handles Kitchen-initiated builds, since they're the only ones whose
annotation stream path we understand.

BUG=chromium:687625
TEST=unit
==========

to

==========
milo: Add a build info Swarming implementation.

Add a BuildInfo implementation for Swarming builds. This currently only
handles Kitchen-initiated builds, since they're the only ones whose
annotation stream path we understand.

This also removes arbitrary host selection, which is a security issue.

BUG=chromium:687625
TEST=unit
==========

[hinoka, 2017-02-07 20:07:25]

lgtm + naming suggestions

Also I think the portion that removes the arbitrary host selection is in a
different CL now right?  Probably should remove that from the description.

https://codereview.chromium.org/2667363002/diff/40001/milo/appengine/swarming...
File milo/appengine/swarming/buildinfo.go (right):

https://codereview.chromium.org/2667363002/diff/40001/milo/appengine/swarming...
milo/appengine/swarming/buildinfo.go:23: // BuildInfoProvider is a configuration
that provides build information.
s/configuration/service/ ?

https://codereview.chromium.org/2667363002/diff/40001/milo/appengine/swarming...
milo/appengine/swarming/buildinfo.go:106: step, err := as.Load(c)
This is an RPC call right? Add a comment here denoting it's doing a fetch

https://codereview.chromium.org/2667363002/diff/40001/milo/appengine/swarming...
milo/appengine/swarming/buildinfo.go:137: func getLogDogAnnotations(c
context.Context, sr *swarming.SwarmingRpcsTaskRequest, projectHint
cfgtypes.ProjectName,
I think "resolveLogDogAnnotations" is clearer

[dnj, 2017-02-07 23:06:09]

https://codereview.chromium.org/2667363002/diff/40001/milo/appengine/swarming...
File milo/appengine/swarming/buildinfo.go (right):

https://codereview.chromium.org/2667363002/diff/40001/milo/appengine/swarming...
milo/appengine/swarming/buildinfo.go:23: // BuildInfoProvider is a configuration
that provides build information.
On 2017/02/07 20:07:24, hinoka wrote:
> s/configuration/service/ ?

Done.

https://codereview.chromium.org/2667363002/diff/40001/milo/appengine/swarming...
milo/appengine/swarming/buildinfo.go:106: step, err := as.Load(c)
On 2017/02/07 20:07:24, hinoka wrote:
> This is an RPC call right? Add a comment here denoting it's doing a fetch

Done.

https://codereview.chromium.org/2667363002/diff/40001/milo/appengine/swarming...
milo/appengine/swarming/buildinfo.go:137: func getLogDogAnnotations(c
context.Context, sr *swarming.SwarmingRpcsTaskRequest, projectHint
cfgtypes.ProjectName,
On 2017/02/07 20:07:24, hinoka wrote:
> I think "resolveLogDogAnnotations" is clearer

Done.

[dnj, 2017-02-08 00:22:37]

Description was changed from

==========
milo: Add a build info Swarming implementation.

Add a BuildInfo implementation for Swarming builds. This currently only
handles Kitchen-initiated builds, since they're the only ones whose
annotation stream path we understand.

This also removes arbitrary host selection, which is a security issue.

BUG=chromium:687625
TEST=unit
==========

to

==========
milo: Add a build info Swarming implementation.

Add a BuildInfo implementation for Swarming builds. This currently only
handles Kitchen-initiated builds, since they're the only ones whose
annotation stream path we understand.

BUG=chromium:687625
TEST=unit
==========

[dnj, 2017-02-08 00:22:40]

The CQ bit was checked by dnj@chromium.org

[dnj, 2017-02-08 00:22:40]

The patchset sent to the CQ was uploaded after l-g-t-m from hinoka@chromium.org
Link to the patchset: https://codereview.chromium.org/2667363002/#ps60001
(title: "Comments.")

[commit-bot: I haz the power, 2017-02-08 00:22:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 00:29:00]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1486513360040270,
"parent_rev": "25d607344cb34abf88981868a27ff64cd93a0554", "commit_rev":
"64c2ca4b695d4427907ee8325515589ecbbae026"}

[commit-bot: I haz the power, 2017-02-08 00:29:04]

Description was changed from

==========
milo: Add a build info Swarming implementation.

Add a BuildInfo implementation for Swarming builds. This currently only
handles Kitchen-initiated builds, since they're the only ones whose
annotation stream path we understand.

BUG=chromium:687625
TEST=unit
==========

to

==========
milo: Add a build info Swarming implementation.

Add a BuildInfo implementation for Swarming builds. This currently only
handles Kitchen-initiated builds, since they're the only ones whose
annotation stream path we understand.

BUG=chromium:687625
TEST=unit

Review-Url: https://codereview.chromium.org/2667363002
Committed:
https://github.com/luci/luci-go/commit/64c2ca4b695d4427907ee8325515589ecbbae026
==========

[commit-bot: I haz the power, 2017-02-08 00:29:06]

Committed patchset #4 (id:60001) as
https://github.com/luci/luci-go/commit/64c2ca4b695d4427907ee8325515589ecbbae026