Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2671633002: Update LogDog client to export its host. (Closed)

Created:
3 years, 10 months ago by dnj
Modified:
3 years, 10 months ago
Reviewers:
hinoka
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Update LogDog client to export its host. Make the LogDog client host field accessible to the client. Defensively confirm to assert that the descriptor is present in the server's response. BUG=chromium:687625 TEST=None Review-Url: https://codereview.chromium.org/2671633002 Committed: https://github.com/luci/luci-go/commit/149de756b08fe70a72945361d12c8353bc8656fa

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M logdog/client/coordinator/client.go View 1 chunk +4 lines, -1 line 0 comments Download
M logdog/client/coordinator/stream.go View 1 chunk +7 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (4 generated)
dnj
PTAL. This set of CLs adds a pRPC service to Milo called "BuildInfo". This service ...
3 years, 10 months ago (2017-02-02 02:57:01 UTC) #2
hinoka
lgtm
3 years, 10 months ago (2017-02-02 21:07:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2671633002/1
3 years, 10 months ago (2017-02-02 21:45:42 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-02-02 21:52:23 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/149de756b08fe70a72945361d12c8353bc8656fa

Powered by Google App Engine
This is Rietveld 408576698