Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 2676153002: Revert of Add compositor support for half-float RGBA buffers and textures (Closed)

Created:
3 years, 10 months ago by Ken Russell (switch to Gerrit)
Modified:
3 years, 10 months ago
CC:
cc-bugs_chromium.org, chromium-reviews, hubbe, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add compositor support for half-float RGBA buffers and textures (patchset #4 id:60001 of https://codereview.chromium.org/2674493003/ ) Reason for revert: Broke all Windows bots on chromium.gpu.fyi waterfall; see https://bugs.chromium.org/p/chromium/issues/detail?id=687346#c4 . Original issue's description: > Add the ResourceFormat RGBA_F16, and appropriate GL and Skia values. > > Add the GPU capability color_buffer_float, to expose if it is possible > to create a RGBA_F16 render target. > > Enable exposing GPU capabilities color_buffer_float and > texture_half_float_linear to non-WebGL GLES2 contexts (e.g, the > compositor context). > > When allocating a RenderPass texture, use RGBA_F16 if the output surface > is high-bit-depth (which will include HDR surfaces). Add the method > OutputSurface::IsHighBitDepth to indicate this property. > > Note that this cannot be tested by the cc pixel tests (the correct way > to test this) because they use a version of Mesa that does not support > floating-point textures. Tests so far have been manual, as we work on > upgrading Mesa. This will be tested by having the pixel tests which > currently run in software and GL mode also run in "GL with high bit > depth output surface" mode. > > BUG=687346 > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel > > Review-Url: https://codereview.chromium.org/2674493003 > Cr-Commit-Position: refs/heads/master@{#448143} > Committed: https://chromium.googlesource.com/chromium/src/+/197ec6b2ea2af1d95c0acdf9a0ebf0cd479fdf40 TBR=enne@chromium.org,jbauman@chromium.org,tsepez@chromium.org,ccameron@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=687346 Review-Url: https://codereview.chromium.org/2676153002 Cr-Commit-Position: refs/heads/master@{#448159} Committed: https://chromium.googlesource.com/chromium/src/+/75c6426dbd63f244b76f512671faafdfc278fdd3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+300 lines, -210 lines) Patch
M cc/output/direct_renderer.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/output/direct_renderer.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M cc/output/gl_renderer.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/output/gl_renderer.cc View 2 chunks +1 line, -7 lines 0 comments Download
M cc/output/software_renderer.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/output/software_renderer.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M cc/raster/gpu_raster_buffer_provider.cc View 1 chunk +1 line, -3 lines 0 comments Download
M cc/raster/raster_buffer_provider.cc View 3 chunks +1 line, -4 lines 0 comments Download
M cc/resources/platform_color.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/resources/platform_color_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M cc/resources/resource_format.h View 1 chunk +1 line, -2 lines 0 comments Download
M cc/resources/resource_format.cc View 6 chunks +0 lines, -7 lines 0 comments Download
M cc/resources/resource_format_utils.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/resources/resource_provider.cc View 5 chunks +2 lines, -13 lines 0 comments Download
M cc/resources/resource_provider_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M gpu/command_buffer/common/capabilities.h View 1 chunk +85 lines, -86 lines 0 comments Download
M gpu/command_buffer/common/capabilities.cc View 1 chunk +86 lines, -1 line 0 comments Download
M gpu/command_buffer/service/feature_info.h View 1 chunk +57 lines, -58 lines 0 comments Download
M gpu/command_buffer/service/feature_info.cc View 5 chunks +60 lines, -8 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/test_helper.cc View 2 chunks +1 line, -2 lines 0 comments Download
M gpu/ipc/common/gpu_command_buffer_traits_multi.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
Ken Russell (switch to Gerrit)
Created Revert of Add compositor support for half-float RGBA buffers and textures
3 years, 10 months ago (2017-02-05 00:33:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2676153002/1
3 years, 10 months ago (2017-02-05 00:33:22 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-02-05 00:36:03 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/75c6426dbd63f244b76f512671fa...

Powered by Google App Engine
This is Rietveld 408576698