Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Issue 2676033002: Give URLRequestJob::GetResponseCode a better default implementation. (Closed)

Created:
3 years, 10 months ago by mmenke
Modified:
3 years, 10 months ago
Reviewers:
Julia Tuttle
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Give URLRequestJob::GetResponseCode a better default implementation. Also remove a couple overrides of the method that are no longer needed, mostly from net test classes. Others can be removed in followup CLs. BUG=688481 R=juliatuttle@chromium.org Review-Url: https://codereview.chromium.org/2676033002 . Cr-Commit-Position: refs/heads/master@{#448087} Committed: https://chromium.googlesource.com/chromium/src/+/3e0a3877d7a54cb14e1646bacb923d2aab3c6b0a

Patch Set 1 #

Patch Set 2 : Missed one #

Patch Set 3 : Add headers #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -42 lines) Patch
M net/test/url_request/url_request_failed_job.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/test/url_request/url_request_failed_job.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M net/test/url_request/url_request_hanging_read_job.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M net/test/url_request/url_request_hanging_read_job.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M net/test/url_request/url_request_mock_data_job.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/test/url_request/url_request_mock_data_job.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M net/test/url_request/url_request_mock_http_job.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/test/url_request/url_request_mock_http_job.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M net/url_request/test_url_request_interceptor.cc View 1 2 2 chunks +5 lines, -1 line 0 comments Download
M net/url_request/url_request_job.cc View 1 chunk +4 lines, -1 line 0 comments Download
M net/url_request/url_request_redirect_job.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/url_request/url_request_redirect_job.cc View 1 chunk +0 lines, -7 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 19 (13 generated)
mmenke
3 years, 10 months ago (2017-02-03 19:47:30 UTC) #4
Julia Tuttle
lgtm!
3 years, 10 months ago (2017-02-03 19:56:49 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2676033002/40001
3 years, 10 months ago (2017-02-03 19:58:31 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2676033002/40001
3 years, 10 months ago (2017-02-03 22:03:42 UTC) #16
mmenke
Committed patchset #3 (id:40001) manually as 3e0a3877d7a54cb14e1646bacb923d2aab3c6b0a (presubmit successful).
3 years, 10 months ago (2017-02-03 22:19:00 UTC) #18
mmenke
3 years, 10 months ago (2017-02-03 22:20:14 UTC) #19
Message was sent while issue was closed.
On 2017/02/03 22:19:00, mmenke (Out Feb 4 to March 5) wrote:
> Committed patchset #3 (id:40001) manually as
> 3e0a3877d7a54cb14e1646bacb923d2aab3c6b0a (presubmit successful).

(CQ seemed borked - all bots passed, other people's patches were being landed,
but this patch sat in read to commit state for over 40 minutes)

Powered by Google App Engine
This is Rietveld 408576698