Give URLRequestJob::GetResponseCode a better default implementation.

Give URLRequestJob::GetResponseCode a better default implementation.

Also remove a couple overrides of the method that are no longer needed,
mostly from net test classes.  Others can be removed in followup CLs.

BUG=688481
R=juliatuttle@chromium.org

Review-Url: https://codereview.chromium.org/2676033002 .
Cr-Commit-Position: refs/heads/master@{#448087}
Committed: https://chromium.googlesource.com/chromium/src/+/3e0a3877d7a54cb14e1646bacb923d2aab3c6b0a

[mmenke, 2017-02-03 19:46:51]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-03 19:47:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mmenke, 2017-02-03 19:47:29]

mmenke@chromium.org changed reviewers:
+ juliatuttle@chromium.org

[mmenke, 2017-02-03 19:50:12]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-03 19:50:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mmenke, 2017-02-03 19:52:15]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-03 19:52:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Julia Tuttle, 2017-02-03 19:56:49]

lgtm!

[mmenke, 2017-02-03 19:57:50]

Description was changed from

==========
Give URLRequestJob::GetResponseCode a better default implementation.

Also remove a couple overrides of the method that are no longer needed,
mostly from test classes.  Others can be removed in followup CLs.

BUG=688481
==========

to

==========
Give URLRequestJob::GetResponseCode a better default implementation.

Also remove a couple overrides of the method that are no longer needed,
mostly from net test classes.  Others can be removed in followup CLs.

BUG=688481
==========

[mmenke, 2017-02-03 19:58:04]

The CQ bit was unchecked by mmenke@chromium.org

[mmenke, 2017-02-03 19:58:08]

The CQ bit was checked by mmenke@chromium.org

[commit-bot: I haz the power, 2017-02-03 19:58:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mmenke, 2017-02-03 22:01:38]

The CQ bit was unchecked by mmenke@chromium.org

[mmenke, 2017-02-03 22:02:28]

The CQ bit was checked by mmenke@chromium.org

[commit-bot: I haz the power, 2017-02-03 22:03:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mmenke, 2017-02-03 22:18:59]

Description was changed from

==========
Give URLRequestJob::GetResponseCode a better default implementation.

Also remove a couple overrides of the method that are no longer needed,
mostly from net test classes.  Others can be removed in followup CLs.

BUG=688481
==========

to

==========
Give URLRequestJob::GetResponseCode a better default implementation.

Also remove a couple overrides of the method that are no longer needed,
mostly from net test classes.  Others can be removed in followup CLs.

BUG=688481
R=juliatuttle@chromium.org

Review-Url: https://codereview.chromium.org/2676033002 .
Cr-Commit-Position: refs/heads/master@{#448087}
Committed:
https://chromium.googlesource.com/chromium/src/+/3e0a3877d7a54cb14e1646bacb92...
==========

[mmenke, 2017-02-03 22:19:00]

Committed patchset #3 (id:40001) manually as
3e0a3877d7a54cb14e1646bacb923d2aab3c6b0a (presubmit successful).

[mmenke, 2017-02-03 22:20:14]

On 2017/02/03 22:19:00, mmenke (Out Feb 4 to March 5) wrote:
> Committed patchset #3 (id:40001) manually as
> 3e0a3877d7a54cb14e1646bacb923d2aab3c6b0a (presubmit successful).

(CQ seemed borked - all bots passed, other people's patches were being landed,
but this patch sat in read to commit state for over 40 minutes)