ServiceWorker: Remove URLRequestJob::GetResponseCode implementations.

ServiceWorker:  Remove URLRequestJob::GetResponseCode implementations.

The default implementation is being modified to get the response code
from the URLRequest's HttpResponseInfo, to ensure it's consistent, and
hopefully we'll eventually be able to remove the method from
URLRequestJob entirely.

BUG=688481
Review-Url: https://codereview.chromium.org/2670243003
Cr-Commit-Position: refs/heads/master@{#448138}
Committed: https://chromium.googlesource.com/chromium/src/+/9f3d62526e92be1ec627cdd4de25104a8e280a5e

[mmenke, 2017-02-03 20:20:42]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-03 20:21:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mmenke, 2017-02-03 20:22:02]

mmenke@chromium.org changed reviewers:
+ falken@chromium.org

[mmenke, 2017-02-03 20:22:03]

[falken]:  PTAL.  Note that the new implementation starts returning the correct
response code a bit later than the old one, since it takes it from URLRequest
rather than the Jobs' internal state, but since none of these URLRequestJob
subclasses call the function themselves, there should be no problem.

[falken, 2017-02-03 21:29:42]

naive question: do we need to modify the default implementation before removing
these? It looks like URLRequestJob::GetResponseCode is just { return -1; }

[mmenke, 2017-02-03 21:39:46]

On 2017/02/03 21:29:42, falken wrote:
> naive question: do we need to modify the default implementation before
removing
> these? It looks like URLRequestJob::GetResponseCode is just { return -1; }

Sorry, should have been clearer.  Note the "depends on patcheset" line above,
which is the CL that changes the default implementation (Currently CQed).

[falken, 2017-02-03 21:41:50]

Ah, missed the dependent patchset part. lgtm.

[mmenke, 2017-02-03 21:42:29]

On 2017/02/03 21:41:50, falken wrote:
> Ah, missed the dependent patchset part. lgtm.

Yea, it's quite easy to miss.  Thanks!

[mmenke, 2017-02-03 22:32:29]

The CQ bit was checked by mmenke@chromium.org

[mmenke, 2017-02-03 22:32:30]

The patchset sent to the CQ was uploaded after l-g-t-m from falken@chromium.org
Link to the patchset: https://codereview.chromium.org/2670243003/#ps20001
(title: "merge")

[commit-bot: I haz the power, 2017-02-03 22:33:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-04 01:09:34]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486161149692520,
"parent_rev": "fadbd7c7b46dc4b338dbe3e2b1bb437a208bba75", "commit_rev":
"9f3d62526e92be1ec627cdd4de25104a8e280a5e"}

[commit-bot: I haz the power, 2017-02-04 01:10:28]

Description was changed from

==========
ServiceWorker:  Remove URLRequestJob::GetResponseCode implementations.

The default implementation is being modified to get the response code
from the URLRequest's HttpResponseInfo, to ensure it's consistent, and
hopefully we'll eventually be able to remove the method from
URLRequestJob entirely.

BUG=688481
==========

to

==========
ServiceWorker:  Remove URLRequestJob::GetResponseCode implementations.

The default implementation is being modified to get the response code
from the URLRequest's HttpResponseInfo, to ensure it's consistent, and
hopefully we'll eventually be able to remove the method from
URLRequestJob entirely.

BUG=688481

Review-Url: https://codereview.chromium.org/2670243003
Cr-Commit-Position: refs/heads/master@{#448138}
Committed:
https://chromium.googlesource.com/chromium/src/+/9f3d62526e92be1ec627cdd4de25...
==========

[commit-bot: I haz the power, 2017-02-04 01:10:29]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9f3d62526e92be1ec627cdd4de25...