Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2672113002: Remove URLRequestJob::GetResponseCode implementations from some tests.

Created:
3 years, 10 months ago by mmenke
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews, tzik, grt+watch_chromium.org, jam, nhiroki, darin-cc_chromium.org, kinuko+fileapi
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove URLRequestJob::GetResponseCode implementations from some tests. The default implementation now gets the response code from the HttpResponseInfo, so most overrides are no longer needed. Eventualy goal is to get rid of the mthod entirely. BUG=688481

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -20 lines) Patch
M chrome/browser/predictors/resource_prefetch_predictor_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/certificate_reporting_service_test_utils.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/certificate_reporting_service_test_utils.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/ssl/ssl_browser_tests.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M components/domain_reliability/uploader_unittest.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/fileapi/file_writer_delegate_unittest.cc View 2 chunks +8 lines, -1 line 0 comments Download
M content/public/test/test_download_request_handler.cc View 2 chunks +0 lines, -6 lines 0 comments Download

Depends on Patchset:

Issue 2676033002 Patch 40001

Messages

Total messages: 4 (4 generated)
mmenke
The CQ bit was checked by mmenke@chromium.org to run a CQ dry run
3 years, 10 months ago (2017-02-03 20:45:15 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2672113002/1
3 years, 10 months ago (2017-02-03 20:45:49 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 10 months ago (2017-02-03 21:18:05 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-02-03 21:18:06 UTC) #4 
Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

Powered by Google App Engine
This is Rietveld 408576698