Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2670413002: Remove BlobURLRequestJob::GetResponseCode(). (Closed)

Created:
3 years, 10 months ago by mmenke
Modified:
3 years, 10 months ago
Reviewers:
jianli
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove BlobURLRequestJob::GetResponseCode(). The default implementation of URLRequestJob::GetResponseCode() is being modified to (mostly) match what it currently does. BUG=688481 Review-Url: https://codereview.chromium.org/2670413002 Cr-Commit-Position: refs/heads/master@{#448103} Committed: https://chromium.googlesource.com/chromium/src/+/4f1a3523846b934a765fd169e6652a28088449be

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M storage/browser/blob/blob_url_request_job.h View 1 chunk +0 lines, -1 line 0 comments Download
M storage/browser/blob/blob_url_request_job.cc View 1 chunk +0 lines, -7 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (8 generated)
mmenke
[jianli]: PTAL. Only difference in the new default implementation (currently CQed) is that it uses ...
3 years, 10 months ago (2017-02-03 20:10:10 UTC) #4
jianli
lgtm
3 years, 10 months ago (2017-02-03 21:56:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2670413002/1
3 years, 10 months ago (2017-02-03 22:21:18 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-03 22:53:58 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4f1a3523846b934a765fd169e665...

Powered by Google App Engine
This is Rietveld 408576698