Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2675883005:
[autofill] Update URL to edit synced Google Payments cards. (Closed)
|
Created:
3 years, 10 months ago by Roger McFarlane (Chromium) Modified:
3 years, 10 months ago CC:
chromium-reviews, rouslan+autofill_chromium.org, rogerm+autofillwatch_chromium.org, sebsg+autofillwatch_chromium.org, browser-components-watch_chromium.org, mathp+autofillwatch_chromium.org, agrieve+watch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[autofill] Update URL to edit synced Google Payments cards.
The URL to edit Google Payments cards has moved from
wallet.google.com to payments.google.com.
BUG=673215
R=bauerb@chromium.org, mathp@chromium.org, jsaul@chromium.org
Review-Url: https://codereview.chromium.org/2675883005
Cr-Commit-Position: refs/heads/master@{#449022}
Committed: https://chromium.googlesource.com/chromium/src/+/fd0974677de6c22205d67b301780ac4af863528f
Patch Set 1 #
Total comments: 4
Patch Set 2 : rebase #
Messages
Total messages: 26 (14 generated)
The CQ bit was checked by rogerm@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== [autofill] Update url to edit synced Google Payments cards. The URL to edit Google Payments cards has moved from wallet.google.com to payments.google.com. BUG=673215 R=bauerb@chromium.org, mathp@chromium.org ========== to ========== [autofill] Update url to edit synced Google Payments cards. The URL to edit Google Payments cards has moved from wallet.google.com to payments.google.com. BUG=673215 R=bauerb@chromium.org, mathp@chromium.org, jsaul@chromium.org ==========
rogerm@chromium.org changed reviewers: + jsaul@google.com
Description was changed from ========== [autofill] Update url to edit synced Google Payments cards. The URL to edit Google Payments cards has moved from wallet.google.com to payments.google.com. BUG=673215 R=bauerb@chromium.org, mathp@chromium.org, jsaul@chromium.org ========== to ========== [autofill] Update URL to edit synced Google Payments cards. The URL to edit Google Payments cards has moved from wallet.google.com to payments.google.com. BUG=673215 R=bauerb@chromium.org, mathp@chromium.org, jsaul@chromium.org ==========
PTAL? The URL to edit Google Payments cards has moved from wallet.google.com to payments.google.com
lgtm, I'll let Jared confirm the url!
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm for URL! Thanks Roger.
bauerb@... friendly ping?
lgtm https://codereview.chromium.org/2675883005/diff/1/chrome/android/java/strings... File chrome/android/java/strings/android_chrome_strings.grd (right): https://codereview.chromium.org/2675883005/diff/1/chrome/android/java/strings... chrome/android/java/strings/android_chrome_strings.grd:334: https://payments.google.com/#paymentMethods Out of curiosity, why is this a resource instead of a constant in code?
rogerm@chromium.org changed reviewers: + gogerald@chromium.org
Thanks! https://codereview.chromium.org/2675883005/diff/1/chrome/android/java/strings... File chrome/android/java/strings/android_chrome_strings.grd (right): https://codereview.chromium.org/2675883005/diff/1/chrome/android/java/strings... chrome/android/java/strings/android_chrome_strings.grd:334: https://payments.google.com/#paymentMethods On 2017/02/07 10:43:52, Bernhard Bauer wrote: > Out of curiosity, why is this a resource instead of a constant in code? Good question. This constant does appear in the code as well (see the other files in this CL. Actually, a basic chromium codesearch doesn't turn up any other occurrences of these string IDs. Mayhaps these no longer even need to be in the grd file? +gogerald: Can you confirm/deny whether these are still in use?
https://codereview.chromium.org/2675883005/diff/1/chrome/android/java/strings... File chrome/android/java/strings/android_chrome_strings.grd (right): https://codereview.chromium.org/2675883005/diff/1/chrome/android/java/strings... chrome/android/java/strings/android_chrome_strings.grd:334: https://payments.google.com/#paymentMethods On 2017/02/08 14:59:48, Roger McFarlane (Chromium) wrote: > On 2017/02/07 10:43:52, Bernhard Bauer wrote: > > Out of curiosity, why is this a resource instead of a constant in code? > > Good question. This constant does appear in the code as well (see the other > files in this CL. > > Actually, a basic chromium codesearch doesn't turn up any other occurrences of > these string IDs. Mayhaps these no longer even need to be in the grd file? > > +gogerald: Can you confirm/deny whether these are still in use? Yes, it is, https://cs.chromium.org/chromium/src/chrome/android/java/src/org/chromium/chr...
https://codereview.chromium.org/2675883005/diff/1/chrome/android/java/strings... File chrome/android/java/strings/android_chrome_strings.grd (right): https://codereview.chromium.org/2675883005/diff/1/chrome/android/java/strings... chrome/android/java/strings/android_chrome_strings.grd:334: https://payments.google.com/#paymentMethods On 2017/02/08 15:04:50, gogerald1 wrote: > On 2017/02/08 14:59:48, Roger McFarlane (Chromium) wrote: > > On 2017/02/07 10:43:52, Bernhard Bauer wrote: > > > Out of curiosity, why is this a resource instead of a constant in code? > > > > Good question. This constant does appear in the code as well (see the other > > files in this CL. > > > > Actually, a basic chromium codesearch doesn't turn up any other occurrences of > > these string IDs. Mayhaps these no longer even need to be in the grd file? > > > > +gogerald: Can you confirm/deny whether these are still in use? > > Yes, it is, > https://cs.chromium.org/chromium/src/chrome/android/java/src/org/chromium/chr... Ah, needed to search without the IDS_ prefix. The android usage doesn't embed the user_index, but maybe these can be removed. I've filed http://crbug/690013
The CQ bit was checked by rogerm@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply patch for
chrome/android/java/strings/android_chrome_strings.grd:
While running git apply --index -p1;
error: patch failed:
chrome/android/java/strings/android_chrome_strings.grd:270
error: chrome/android/java/strings/android_chrome_strings.grd: patch does not
apply
Patch: chrome/android/java/strings/android_chrome_strings.grd
Index: chrome/android/java/strings/android_chrome_strings.grd
diff --git a/chrome/android/java/strings/android_chrome_strings.grd
b/chrome/android/java/strings/android_chrome_strings.grd
index
8fca2d2f0f019ba5308849e12a87d37217a72d9c..e529678b9347ffb7e015d1cc894b80f0c0920d02
100644
--- a/chrome/android/java/strings/android_chrome_strings.grd
+++ b/chrome/android/java/strings/android_chrome_strings.grd
@@ -270,7 +270,7 @@ CHAR-LIMIT guidelines:
<!-- Autofill and Payments preferences -->
<message name="IDS_PREFS_AUTOFILL_AND_PAYMENTS" desc="Title of Autofill
and payments settings prefrences. [CHAR-LIMIT=32]">
Autofill and payments
- </message>
+ </message>
<message name="IDS_AUTOFILL_SWITCH" desc="Title for 'Autofill forms'
switch preference, which controls whether personal data can be automatically
filled into web page forms. [CHAR-LIMIT=32]">
Autofill forms
</message>
@@ -331,10 +331,10 @@ CHAR-LIMIT guidelines:
Edit
</message>
<message name="IDS_AUTOFILL_MANAGE_WALLET_CARDS_URL" desc="URL for
managing wallet credit cards" translateable="false">
- https://wallet.google.com/manage/paymentMethods
+ https://payments.google.com/#paymentMethods
</message>
<message name="IDS_AUTOFILL_MANAGE_WALLET_ADDRESSES_URL" desc="URL for
managing wallet addresses" translateable="false">
- https://wallet.google.com/manage/addressBook
+ https://payments.google.com/#paymentMethods
</message>
<message name="IDS_AUTOFILL_FROM_GOOGLE_ACCOUNT_LONG" desc="Text that
indicates an address or credit card came from Google servers.">
From Google Payments
The CQ bit was checked by rogerm@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org, mathp@chromium.org, jsaul@google.com Link to the patchset: https://codereview.chromium.org/2675883005/#ps20001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486571102814280,
"parent_rev": "3ea335139f6f337d8cc46250fd86f8965f6d0a53", "commit_rev":
"fd0974677de6c22205d67b301780ac4af863528f"}
Message was sent while issue was closed.
Description was changed from ========== [autofill] Update URL to edit synced Google Payments cards. The URL to edit Google Payments cards has moved from wallet.google.com to payments.google.com. BUG=673215 R=bauerb@chromium.org, mathp@chromium.org, jsaul@chromium.org ========== to ========== [autofill] Update URL to edit synced Google Payments cards. The URL to edit Google Payments cards has moved from wallet.google.com to payments.google.com. BUG=673215 R=bauerb@chromium.org, mathp@chromium.org, jsaul@chromium.org Review-Url: https://codereview.chromium.org/2675883005 Cr-Commit-Position: refs/heads/master@{#449022} Committed: https://chromium.googlesource.com/chromium/src/+/fd0974677de6c22205d67b301780... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/fd0974677de6c22205d67b301780... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
