Make LUTs independent of YUV in cc shaders

Make LUTs independent of YUV in cc shaders

Also, make YUV->RGB conversion use the already existing color matrix
instead of having a separate one.

This Cl is in preparation for adding color conversion support to
TextureQuad which in turn will be needed to implement hardware-
decoded HDR on windows.

BUG=682416
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

[hubbe, 2017-02-02 18:59:25]

Description was changed from

==========
Make LUTs independent of YUV in cc shaders

Also, make YUV->RGB conversion use the already existing color matrix
instead of having a separate one.

This Cl is in preparation for adding color conversion support to
TextureQuad which in turn will be needed to implement hardware-
decoded HDR on windows.

BUG=682416
==========

to

==========
Make LUTs independent of YUV in cc shaders

Also, make YUV->RGB conversion use the already existing color matrix
instead of having a separate one.

This Cl is in preparation for adding color conversion support to
TextureQuad which in turn will be needed to implement hardware-
decoded HDR on windows.

BUG=682416
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[hubbe, 2017-02-02 18:59:32]

The CQ bit was checked by hubbe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-02 18:59:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hubbe, 2017-02-02 18:59:56]

Description was changed from

==========
Make LUTs independent of YUV in cc shaders

Also, make YUV->RGB conversion use the already existing color matrix
instead of having a separate one.

This Cl is in preparation for adding color conversion support to
TextureQuad which in turn will be needed to implement hardware-
decoded HDR on windows.

BUG=682416
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Make LUTs independent of YUV in cc shaders

Also, make YUV->RGB conversion use the already existing color matrix
instead of having a separate one.

This Cl is in preparation for adding color conversion support to
TextureQuad which in turn will be needed to implement hardware-
decoded HDR on windows.

BUG=682416
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[hubbe, 2017-02-02 18:59:56]

hubbe@chromium.org changed reviewers:
+ ccameron@chromium.org

[commit-bot: I haz the power, 2017-02-02 19:12:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-02 19:12:11]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[hubbe, 2017-02-02 19:43:34]

The CQ bit was checked by hubbe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-02 19:44:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-02 21:04:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-02 21:04:44]

Dry run: Try jobs failed on following builders:
  linux_trusty_blink_rel on master.tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_trusty_blink_rel/b...)

[hubbe, 2017-02-02 21:27:32]

CRreview says this is "unsent", so I'm sending it again just to be sure.

[hubbe, 2017-02-02 22:19:51]

Manually inspected the layout tests failures.
They are all single-pixel rounding changes.
We should re-baseline the tests after this change.

[ccameron, 2017-02-02 23:38:07]

I like the general structure.

There are a handful of issues, and this will merge-conflict-crazily with the
other YUV work that I'm doing.

I'd like to take a stab at incorporating this patch into the follow-on that I
have for https://codereview.chromium.org/2670773002/ -- it should be ready in a
couple of hours -- does that sound OK?

https://codereview.chromium.org/2675813002/diff/20001/cc/output/shader.cc
File cc/output/shader.cc (right):

https://codereview.chromium.org/2675813002/diff/20001/cc/output/shader.cc#new...
cc/output/shader.cc:884: 
I'm working on a patch to merge (resource_multiplier and resource_offset) with
(yuv_matrix| and yuv_adj). I'd like to try to merge that in, since I think it'll
make adding your easier.

https://codereview.chromium.org/2675813002/diff/20001/cc/output/shader.h
File cc/output/shader.h (left):

https://codereview.chromium.org/2675813002/diff/20001/cc/output/shader.h#oldc...
cc/output/shader.h:133: enum ColorConversionMode {
Please leave this as an enum instead of a boolean (I've been being emphatic
about using enums instead of booleans here because otherwise the shader
descriptions are "false, true, false, false").

https://codereview.chromium.org/2675813002/diff/20001/cc/output/shader.h#oldc...
cc/output/shader.h:299: int yuv_adj_location_ = -1;
Please continue to use these uniforms instead of color_matrix.

The |color_matrix| uniform is for color filters (e.g, a sepia filter), which is
orthogonal to color conversion (and, in principle, could be applied at the same
time as a YUV to RGB conversion).

[ccameron, 2017-02-03 00:44:11]

I've incorporated (most of) this into https://codereview.chromium.org/2674763003
-- does that look like a good point to go from?

[chromium-reviews, 2017-02-03 01:02:20]

Yes it does. I might need to break out the resource offset/multiplier
matrix so that it can be used on RGB textures, but if I do, I can do that
later.

     /Hubbe

On Thu, Feb 2, 2017 at 4:44 PM, <ccameron@chromium.org> wrote:

> I've incorporated (most of) this into https://codereview.chromium.
> org/2674763003
> -- does that look like a good point to go from?
>
> https://codereview.chromium.org/2675813002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.