Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(660)

Issue 2674763003: cc: Separate YUV from LUT color conversion (Closed)

Created:
3 years, 10 months ago by ccameron
Modified:
3 years, 10 months ago
Reviewers:
hubbe
CC:
chromium-reviews, cc-bugs_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Separate YUV from LUT color conversion Merge all of resource_multiplier, resource_offset, yuv_matrix, and yuv_adj into a single variable, yuv_and_resource_matrix. Use this regardless of using a LUT for color conversion. Move LUT based color conversion out of YUV to RGB code. In this instance, use yuv_and_resource_matrix only for resource scaling and offset. Don't actually delete the old YUV code yet (that's coming next). BUG=682416 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2674763003 Cr-Commit-Position: refs/heads/master@{#447975} Committed: https://chromium.googlesource.com/chromium/src/+/c65bdaaa36e9237c9ef1f11ea58b89b828fcea51

Patch Set 1 #

Patch Set 2 : Move uniforms out of YUV #

Patch Set 3 : Add layout test changes #

Patch Set 4 : More rebaselines #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -109 lines) Patch
M cc/output/gl_renderer.cc View 7 chunks +43 lines, -36 lines 0 comments Download
M cc/output/gl_renderer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/output/program_binding.h View 1 chunk +2 lines, -9 lines 0 comments Download
M cc/output/shader.h View 2 chunks +8 lines, -8 lines 0 comments Download
M cc/output/shader.cc View 1 4 chunks +38 lines, -53 lines 0 comments Download
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 3 2 chunks +15 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
ccameron
ptal -- this is merges https://codereview.chromium.org/2675813002/ with the patches that I had in-flight for YUV2RGB ...
3 years, 10 months ago (2017-02-03 00:48:29 UTC) #4
hubbe
lgtm
3 years, 10 months ago (2017-02-03 00:57:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2674763003/20001
3 years, 10 months ago (2017-02-03 02:17:11 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/111913)
3 years, 10 months ago (2017-02-03 03:18:23 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2674763003/40001
3 years, 10 months ago (2017-02-03 07:16:10 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2674763003/60001
3 years, 10 months ago (2017-02-03 08:41:18 UTC) #15
commit-bot: I haz the power
3 years, 10 months ago (2017-02-03 12:03:40 UTC) #18
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/c65bdaaa36e9237c9ef1f11ea58b...

Powered by Google App Engine
This is Rietveld 408576698