[SPInvalidation] Use GeometryMapper in PaintLayerClipper for paint.

[SPInvalidation] Use GeometryMapper in PaintLayerClipper for paint.

This turns on GeometryMapper for all use-cases of PaintLayerClipper in painting.
It does not include any from computing SPv1 compositing or from computing
recursive bounding boxes. SPv1 compositing happens before pre-paint, and hence
is not available for use of property trees. Recursive bounding boxes, e.g.
via PaintLayer::physicalBoundingBoxIncludingStackingChildren, are called during
paint invalidation, which cannot currently be supported because they imply
access to property trees for children during pre-paint, which have not yet
been computed.

Future work will fix the problem with PaintLayer::physicalBoundingBoxIncludingStackingChildren.

BUG=683733
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2671853003
Cr-Commit-Position: refs/heads/master@{#449899}
Committed: https://chromium.googlesource.com/chromium/src/+/56850c99e856e368af5f440d75d8e8bdb13608f1

[chrishtr, 2017-02-03 01:07:24]

Description was changed from

==========
none


none

BUG=
==========

to

==========
none


none

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[chrishtr, 2017-02-03 01:07:59]

Description was changed from

==========
none


none

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Use GeometryMapper in PaintLayerClipper for SPInvalidation.

BUG=683733
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[chrishtr, 2017-02-03 01:08:15]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-03 01:08:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-03 01:52:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-03 01:52:30]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[chrishtr, 2017-02-04 21:25:04]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-04 21:25:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-04 21:26:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-04 21:26:40]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[chrishtr, 2017-02-04 21:50:31]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-04 21:50:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-04 23:17:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-04 23:17:03]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[chrishtr, 2017-02-07 20:15:27]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-07 20:16:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-07 20:36:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-07 20:36:23]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[chrishtr, 2017-02-07 21:22:44]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-07 21:24:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-07 22:26:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-07 22:26:21]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[chrishtr, 2017-02-08 01:04:23]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-08 01:05:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chrishtr, 2017-02-08 01:06:10]

Description was changed from

==========
Use GeometryMapper in PaintLayerClipper for SPInvalidation.

BUG=683733
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Use GeometryMapper in PaintLayerClipper for SPInvalidation.

This turns on GeometryMapper for all use-cases of PaintLayerClipper in painting.
It does not include any from computing SPv1 compositing or from computing
recursive bounding boxes.

BUG=683733
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[chrishtr, 2017-02-08 01:08:34]

Description was changed from

==========
Use GeometryMapper in PaintLayerClipper for SPInvalidation.

This turns on GeometryMapper for all use-cases of PaintLayerClipper in painting.
It does not include any from computing SPv1 compositing or from computing
recursive bounding boxes.

BUG=683733
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
[SPInvalidation] Use GeometryMapper in PaintLayerClipper for paint.

This turns on GeometryMapper for all use-cases of PaintLayerClipper in painting.
It does not include any from computing SPv1 compositing or from computing
recursive bounding boxes. SPv1 compositing happens before pre-paint, and hence
is not available for use of property trees. Recursive bounding boxes, e.g.
via PaintLayer::physicalBoundingBoxIncludingStackingChildren, are called during
paint invalidation, which cannot currently be supported because they imply
access to property trees for children during pre-paint, which have not yet
been computed.

Future work will fix the problem with
PaintLayer::physicalBoundingBoxIncludingStackingChildren.

BUG=683733
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[commit-bot: I haz the power, 2017-02-08 02:33:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-08 02:33:30]

Dry run: Try jobs failed on following builders:
  linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)

[chrishtr, 2017-02-09 23:31:48]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[chrishtr, 2017-02-09 23:32:19]

chrishtr@chromium.org changed reviewers:
+ pdr@chromium.org, wangxiaojunfive@gmail.com

[chrishtr, 2017-02-09 23:32:20]

Running performance tests now.

https://codereview.chromium.org/2671853003/diff/100001/third_party/WebKit/Lay...
File third_party/WebKit/LayoutTests/svg/overflow/overflow-on-foreignObject.svg
(left):

https://codereview.chromium.org/2671853003/diff/100001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/svg/overflow/overflow-on-foreignObject.svg:6:
NOTE: This is currently BROKEN in WebKit. We're clipping the viewport of
<foreignObject> correctly,
This test now works correctly.

[commit-bot: I haz the power, 2017-02-09 23:32:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chrishtr, 2017-02-09 23:33:18]

chrishtr@chromium.org changed reviewers:
+ wangxianzhu@chromium.org
- wangxiaojunfive@gmail.com

[commit-bot: I haz the power, 2017-02-10 00:57:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 00:57:37]

Dry run: This issue passed the CQ dry run.

[pdr., 2017-02-10 20:51:08]

https://codereview.chromium.org/2671853003/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/frame/FrameView.cpp (right):

https://codereview.chromium.org/2671853003/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/frame/FrameView.cpp:2820: return
frame().localFrameRoot()->view()->m_geometryMapper.get();
Can you DCHECK here to prevent calling without sp?
DCHECK(RuntimeEnabledFeatures::slimmingPaintInvalidationEnabled());

Wdyt of calling returning a reference, creating a new instance in this function
if needed. This would let us assert here that the document lifecycle is at least
PrePaint.

https://codereview.chromium.org/2671853003/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/frame/FrameView.cpp:2956: // of
nit: indentation

https://codereview.chromium.org/2671853003/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/frame/FrameView.cpp:2958:
m_geometryMapper->clearCache();
Can we assert that geometry mapper isn't used between here and the prepaint walk
instead of clearing the cache here? I think all uses would be bugs since the
data is stale.

https://codereview.chromium.org/2671853003/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/frame/FrameView.h (right):

https://codereview.chromium.org/2671853003/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/frame/FrameView.h:830: GeometryMapper*
geometryMapper();
Please add a comment that this returns the root frame's geometry mapper.

https://codereview.chromium.org/2671853003/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/paint/PaintLayer.cpp (right):

https://codereview.chromium.org/2671853003/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/paint/PaintLayer.cpp:2953: PaintLayerClipper
PaintLayer::clipper(bool useGeometryMapper) const {
Can you add an enum for UseGeometryMapper to make the false/true's easier to
understand?

I worry we're failing to use the mapper in some cases and using it when we
shouldn't in others. Instead of passing this in at the callsites, could this
function pass a geometrymapper if the document lifecycle allows it, and not
otherwise? If there are cases when recursion should disallow it, maybe an
optional argument could be used for that?

IOW, something like:
PaintLayerClipper PaintLayer::clipper() const {
  GeometryMapper* geometryMapper = nullptr;
  if (RuntimeEnabledFeatures::slimmingPaintInvalidationEnabled()) {
    if (m_layoutObject->document()->lifecycle() >= InPrePaint)
      geometryMapper = ...
  }
  return PaintLayerClipper(*this, geometryMapper);
}

[chrishtr, 2017-02-10 22:56:37]

https://codereview.chromium.org/2671853003/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/frame/FrameView.cpp (right):

https://codereview.chromium.org/2671853003/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/frame/FrameView.cpp:2820: return
frame().localFrameRoot()->view()->m_geometryMapper.get();
On 2017/02/10 at 20:51:04, pdr. wrote:
> Can you DCHECK here to prevent calling without sp?
> DCHECK(RuntimeEnabledFeatures::slimmingPaintInvalidationEnabled());
> 
> Wdyt of calling returning a reference, creating a new instance in this
function if needed. This would let us assert here that the document lifecycle is
at least PrePaint.

Done.

https://codereview.chromium.org/2671853003/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/frame/FrameView.cpp:2956: // of
On 2017/02/10 at 20:51:03, pdr. wrote:
> nit: indentation

Moved.

https://codereview.chromium.org/2671853003/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/frame/FrameView.cpp:2958:
m_geometryMapper->clearCache();
On 2017/02/10 at 20:51:03, pdr. wrote:
> Can we assert that geometry mapper isn't used between here and the prepaint
walk instead of clearing the cache here? I think all uses would be bugs since
the data is stale.

Done, via suggestion from above.

https://codereview.chromium.org/2671853003/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/frame/FrameView.h (right):

https://codereview.chromium.org/2671853003/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/frame/FrameView.h:830: GeometryMapper*
geometryMapper();
On 2017/02/10 at 20:51:06, pdr. wrote:
> Please add a comment that this returns the root frame's geometry mapper.

Done.

https://codereview.chromium.org/2671853003/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/paint/PaintLayer.cpp (right):

https://codereview.chromium.org/2671853003/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/paint/PaintLayer.cpp:2953: PaintLayerClipper
PaintLayer::clipper(bool useGeometryMapper) const {
On 2017/02/10 at 20:51:07, pdr. wrote:
> Can you add an enum for UseGeometryMapper to make the false/true's easier to
understand?

Done.

> 
> I worry we're failing to use the mapper in some cases and using it when we
shouldn't in others. Instead of passing this in at the callsites, could this
function pass a geometrymapper if the document lifecycle allows it, and not
otherwise? If there are cases when recursion should disallow it, maybe an
optional argument could be used for that?
> 
> IOW, something like:
> PaintLayerClipper PaintLayer::clipper() const {
>   GeometryMapper* geometryMapper = nullptr;
>   if (RuntimeEnabledFeatures::slimmingPaintInvalidationEnabled()) {
>     if (m_layoutObject->document()->lifecycle() >= InPrePaint)
>       geometryMapper = ...
>   }
>   return PaintLayerClipper(*this, geometryMapper);
> }

To date we do not have code which is conditional on lifecycle state, to my
knowledge. 
Instead we use it only for assertions.

[chrishtr, 2017-02-10 22:56:44]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-10 22:57:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pdr., 2017-02-10 23:19:20]

https://codereview.chromium.org/2671853003/diff/140001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/frame/FrameView.cpp (right):

https://codereview.chromium.org/2671853003/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/frame/FrameView.cpp:3061: // of
Nit: indentation.

https://codereview.chromium.org/2671853003/diff/140001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp (right):

https://codereview.chromium.org/2671853003/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp:231:
paintLayer.clipper(PaintLayer::DoNotUseGeometryMapper)
Should we use the mapper here since it's called through paintLayerContents?

[chrishtr, 2017-02-10 23:21:22]

https://codereview.chromium.org/2671853003/diff/140001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp (right):

https://codereview.chromium.org/2671853003/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp:231:
paintLayer.clipper(PaintLayer::DoNotUseGeometryMapper)
On 2017/02/10 at 23:19:20, pdr. wrote:
> Should we use the mapper here since it's called through paintLayerContents?

No, because of line 229.

[chrishtr, 2017-02-10 23:23:22]

https://codereview.chromium.org/2671853003/diff/140001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/frame/FrameView.cpp (right):

https://codereview.chromium.org/2671853003/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/frame/FrameView.cpp:3061: // of
On 2017/02/10 at 23:19:20, pdr. wrote:
> Nit: indentation.

Done.

[pdr., 2017-02-10 23:23:37]

LGTM % FrameView.cpp comment

https://codereview.chromium.org/2671853003/diff/140001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp (right):

https://codereview.chromium.org/2671853003/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp:231:
paintLayer.clipper(PaintLayer::DoNotUseGeometryMapper)
On 2017/02/10 at 23:21:22, chrishtr wrote:
> On 2017/02/10 at 23:19:20, pdr. wrote:
> > Should we use the mapper here since it's called through paintLayerContents?
> 
> No, because of line 229.

d'oh!

[chrishtr, 2017-02-10 23:25:46]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2017-02-10 23:25:46]

Cool thanks for the review. The perf job tools are being annoying. Going to
commit this
and watch closely. Yell if you disagree (which is fine, just hoping to make fast
progress
while M58 is still weeks away from cut).

[commit-bot: I haz the power, 2017-02-10 23:26:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pdr., 2017-02-10 23:31:38]

On 2017/02/10 at 23:25:46, chrishtr wrote:
> Cool thanks for the review. The perf job tools are being annoying. Going to
commit this
> and watch closely. Yell if you disagree (which is fine, just hoping to make
fast progress
> while M58 is still weeks away from cut).

SGTM, lets check https://chromeperf.appspot.com/group_report?rev=[rev id] after
this lands.

(Don't feel sad if results aren't there tomorrow, it can take 24hr to get all
the android bots reporting)

[commit-bot: I haz the power, 2017-02-11 01:01:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-11 01:01:20]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[chrishtr, 2017-02-11 01:01:47]

The CQ bit was checked by chrishtr@chromium.org

[commit-bot: I haz the power, 2017-02-11 01:02:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-11 02:26:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-11 02:26:25]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[chrishtr, 2017-02-11 22:06:15]

The CQ bit was checked by chrishtr@chromium.org

[commit-bot: I haz the power, 2017-02-11 22:06:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-11 22:47:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-11 22:47:31]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[chrishtr, 2017-02-11 23:05:07]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-11 23:05:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chrishtr, 2017-02-12 17:01:20]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-12 17:02:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-12 18:23:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-12 18:23:10]

Dry run: This issue passed the CQ dry run.

[chrishtr, 2017-02-12 19:24:20]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2017-02-12 19:24:20]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/2671853003/#ps280001
(title: "none")

[commit-bot: I haz the power, 2017-02-12 19:24:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chrishtr, 2017-02-12 19:24:34]

https://codereview.chromium.org/2671853003/diff/280001/third_party/WebKit/Sou...
File third_party/WebKit/Source/web/PageWidgetDelegate.cpp (right):

https://codereview.chromium.org/2671853003/diff/280001/third_party/WebKit/Sou...
third_party/WebKit/Source/web/PageWidgetDelegate.cpp:86:
view->updateAllLifecyclePhasesExceptPaint();
Fixed this bug in patch set 15. This call site happens on Android
for painting disambiguation dialogs, in response to a hit test. But hit
testing currently does not run pre-paint.

[commit-bot: I haz the power, 2017-02-12 19:33:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-12 19:33:49]

Failed to apply patch for third_party/WebKit/Source/web/PageWidgetDelegate.cpp:
While running git apply --index -p1;
  error: patch failed: third_party/WebKit/Source/web/PageWidgetDelegate.cpp:83
  error: third_party/WebKit/Source/web/PageWidgetDelegate.cpp: patch does not
apply

Patch:       third_party/WebKit/Source/web/PageWidgetDelegate.cpp
Index: third_party/WebKit/Source/web/PageWidgetDelegate.cpp
diff --git a/third_party/WebKit/Source/web/PageWidgetDelegate.cpp
b/third_party/WebKit/Source/web/PageWidgetDelegate.cpp
index
a0fbb32574f133ce15f1714534835fd5ad2bfe09..ce6fedd74b4264a97bf15b71ddfbadf20413715b
100644
--- a/third_party/WebKit/Source/web/PageWidgetDelegate.cpp
+++ b/third_party/WebKit/Source/web/PageWidgetDelegate.cpp
@@ -83,6 +83,7 @@ static void paintInternal(Page& page,
 
     IntRect dirtyRect(rect);
     FrameView* view = root.view();
+    view->updateAllLifecyclePhasesExceptPaint();
     if (view) {
       ClipRecorder clipRecorder(paintContext, pictureBuilder,
                                 DisplayItem::kPageWidgetDelegateClip,

[chrishtr, 2017-02-12 21:00:45]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2017-02-12 21:00:45]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/2671853003/#ps300001
(title: "Merge branch 'master' into paintlayerclipper")

[commit-bot: I haz the power, 2017-02-12 21:01:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-12 22:31:01]

CQ is committing da patch.

Bot data: {"patchset_id": 300001, "attempt_start_ts": 1486933245385150,
"parent_rev": "09885722cd8637e59680a1996bac98454cad4bf7", "commit_rev":
"56850c99e856e368af5f440d75d8e8bdb13608f1"}

[commit-bot: I haz the power, 2017-02-12 22:31:41]

Description was changed from

==========
[SPInvalidation] Use GeometryMapper in PaintLayerClipper for paint.

This turns on GeometryMapper for all use-cases of PaintLayerClipper in painting.
It does not include any from computing SPv1 compositing or from computing
recursive bounding boxes. SPv1 compositing happens before pre-paint, and hence
is not available for use of property trees. Recursive bounding boxes, e.g.
via PaintLayer::physicalBoundingBoxIncludingStackingChildren, are called during
paint invalidation, which cannot currently be supported because they imply
access to property trees for children during pre-paint, which have not yet
been computed.

Future work will fix the problem with
PaintLayer::physicalBoundingBoxIncludingStackingChildren.

BUG=683733
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
[SPInvalidation] Use GeometryMapper in PaintLayerClipper for paint.

This turns on GeometryMapper for all use-cases of PaintLayerClipper in painting.
It does not include any from computing SPv1 compositing or from computing
recursive bounding boxes. SPv1 compositing happens before pre-paint, and hence
is not available for use of property trees. Recursive bounding boxes, e.g.
via PaintLayer::physicalBoundingBoxIncludingStackingChildren, are called during
paint invalidation, which cannot currently be supported because they imply
access to property trees for children during pre-paint, which have not yet
been computed.

Future work will fix the problem with
PaintLayer::physicalBoundingBoxIncludingStackingChildren.

BUG=683733
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2671853003
Cr-Commit-Position: refs/heads/master@{#449899}
Committed:
https://chromium.googlesource.com/chromium/src/+/56850c99e856e368af5f440d75d8...
==========

[commit-bot: I haz the power, 2017-02-12 22:31:42]

Committed patchset #16 (id:300001) as
https://chromium.googlesource.com/chromium/src/+/56850c99e856e368af5f440d75d8...