[SPInvalidation] Use GeometryMapper in PaintLayerClipper for paint.

third_party/WebKit/Source/core/frame/FrameView.cpp

 /*
  * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
  *                     1999 Lars Knoll <knoll@kde.org>
  *                     1999 Antti Koivisto <koivisto@kde.org>
  *                     2000 Dirk Mueller <mueller@kde.org>
  * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
  *           (C) 2006 Graham Dennis (graham.dennis@gmail.com)
  *           (C) 2006 Alexey Proskuryakov (ap@nypop.com)
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
@@ skipping 2798 matching lines @@
 
 void FrameView::updateWidgetGeometriesIfNeeded() {
   if (!m_needsUpdateWidgetGeometries)
     return;
 
   m_needsUpdateWidgetGeometries = false;
 
   updateWidgetGeometries();
 }
 
+GeometryMapper* FrameView::geometryMapper() {
+  return frame().localFrameRoot()->view()->m_geometryMapper.get();

[pdr., 2017/02/10 20:51:04]

Can you DCHECK here to prevent calling without sp?
DCHECK(RuntimeEnabledFeatures::slimmingPaintInvalidationEnabled());

Wdyt of calling returning a reference, creating a new instance in this function
if needed. This would let us assert here that the document lifecycle is at least
PrePaint.

[chrishtr, 2017/02/10 22:56:36]

Done.

+}
+
 void FrameView::updateAllLifecyclePhases() {
   frame().localFrameRoot()->view()->updateLifecyclePhasesInternal(
       DocumentLifecycle::PaintClean);
 }
 
 // TODO(chrishtr): add a scrolling update lifecycle phase.
 void FrameView::updateLifecycleToCompositingCleanPlusScrolling() {
   if (RuntimeEnabledFeatures::slimmingPaintV2Enabled()) {
     updateAllLifecyclePhasesExceptPaint();
   } else {
@@ skipping 109 matching lines @@
   if (LayoutViewItem view = layoutViewItem()) {
     forAllNonThrottledFrameViews([](FrameView& frameView) {
       frameView.checkDoesNotNeedLayout();
       frameView.m_allowsLayoutInvalidationAfterLayoutClean = false;
     });
 
     {
       TRACE_EVENT1("devtools.timeline", "UpdateLayerTree", "data",
                    InspectorUpdateLayerTreeEvent::data(m_frame.get()));
 
+      if (RuntimeEnabledFeatures::slimmingPaintInvalidationEnabled()) {
+        if (!m_geometryMapper)
+          m_geometryMapper.reset(new GeometryMapper());
+        // TODO(chrishtr): the cache only needs to be invalidated if one or more
+        // of

[pdr., 2017/02/10 20:51:03]

nit: indentation

[chrishtr, 2017/02/10 22:56:36]

Moved.

+        // the property tree nodes changed.
+        m_geometryMapper->clearCache();

[pdr., 2017/02/10 20:51:03]

Can we assert that geometry mapper isn't used between here and the prepaint walk
instead of clearing the cache here? I think all uses would be bugs since the
data is stale.

[chrishtr, 2017/02/10 22:56:36]

Done, via suggestion from above.

+      }
+
       if (!RuntimeEnabledFeatures::slimmingPaintV2Enabled()) {
         view.compositor()->updateIfNeededRecursive();
       } else {
         forAllNonThrottledFrameViews([](FrameView& frameView) {
           frameView.layoutView()->layer()->updateDescendantDependentFlags();
           frameView.layoutView()->commitPendingSelection();
         });
       }
 
       scrollContentsIfNeededRecursive();
@@ skipping 67 matching lines @@
   }
   m_anchoringAdjustmentQueue.clear();
 }
 
 void FrameView::prePaint() {
   TRACE_EVENT0("blink", "FrameView::prePaint");
 
   if (!m_paintController)
     m_paintController = PaintController::create();
 
-  if (!m_geometryMapper)
-    m_geometryMapper.reset(new GeometryMapper());
-  // TODO(chrishtr): the cache only needs to be invalidated if one or more of
-  // the property tree nodes changed.
-  m_geometryMapper->clearCache();
-
   forAllNonThrottledFrameViews([](FrameView& frameView) {
     frameView.lifecycle().advanceTo(DocumentLifecycle::InPrePaint);
     if (frameView.canThrottleRendering()) {
       // This frame can be throttled but not throttled, meaning we are not in an
       // AllowThrottlingScope. Now this frame may contain dirty paint flags, and
       // we need to propagate the flags into the ancestor chain so that
       // PrePaintTreeWalk can reach this frame.
       frameView.setNeedsPaintPropertyUpdate();
     }
   });
@@ skipping 2050 matching lines @@
     std::unique_ptr<CompositorAnimationTimeline> timeline) {
   m_animationTimeline = std::move(timeline);
 }
 
 void FrameView::setAnimationHost(
     std::unique_ptr<CompositorAnimationHost> host) {
   m_animationHost = std::move(host);
 }
 
 }  // namespace blink