third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp - Issue 2671853003: [SPInvalidation] Use GeometryMapper in PaintLayerClipper for paint.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

Issue 2671853003: [SPInvalidation] Use GeometryMapper in PaintLayerClipper for paint. (Closed)

Patch Set: Merge branch 'master' into paintlayerclipper Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutTreeAsText.cpp ('k') | third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

diff --git a/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp b/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

index 5b80b63ca91527a3a2e1c4892fcb2cf77654b179..b48f2aee7e78e8807f186236d671450f7e03476e 100644

--- a/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

+++ b/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

@@ -547,7 +547,9 @@ void CompositedLayerMapping::

IgnoreOverlayScrollbarSize);

clipRectsContext.setIgnoreOverflowClip();

LayoutRect unsnappedParentClipRect =

- m_owningLayer.clipper().backgroundClipRect(clipRectsContext).rect();

+ m_owningLayer.clipper(PaintLayer::DoNotUseGeometryMapper)

+ .backgroundClipRect(clipRectsContext)

+ .rect();

IntRect parentClipRect = pixelSnappedIntRect(unsnappedParentClipRect);

owningLayerIsClipped = parentClipRect != LayoutRect::infiniteIntRect();

@@ -1142,7 +1144,9 @@ void CompositedLayerMapping::updateAncestorClippingLayerGeometry(

PaintingClipRectsIgnoringOverflowClip,

IgnoreOverlayScrollbarSize);

IntRect parentClipRect = pixelSnappedIntRect(

- m_owningLayer.clipper().backgroundClipRect(clipRectsContext).rect());

+ m_owningLayer.clipper(PaintLayer::DoNotUseGeometryMapper)

+ .backgroundClipRect(clipRectsContext)

+ .rect());

ASSERT(parentClipRect != LayoutRect::infiniteIntRect());

m_ancestorClippingLayer->setPosition(

FloatPoint(parentClipRect.location() - graphicsLayerParentLocation));

@@ -2860,10 +2864,10 @@ IntRect CompositedLayerMapping::localClipRectForSquashedLayer(

// these clip rects or otherwise optimizing.

ClipRectsContext clipRectsContext(ancestorPaintInfo->paintLayer,

UncachedClipRects);

- IntRect parentClipRect =

- pixelSnappedIntRect(paintInfo.paintLayer->clipper()

- .backgroundClipRect(clipRectsContext)

- .rect());

+ IntRect parentClipRect = pixelSnappedIntRect(

+ paintInfo.paintLayer->clipper(PaintLayer::DoNotUseGeometryMapper)

+ .backgroundClipRect(clipRectsContext)

+ .rect());

ASSERT(parentClipRect != LayoutRect::infiniteIntRect());

// Convert from ancestor to local coordinates.