third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp - Issue 2671853003: [SPInvalidation] Use GeometryMapper in PaintLayerClipper for paint.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp

Issue 2671853003: [SPInvalidation] Use GeometryMapper in PaintLayerClipper for paint. (Closed)

Patch Set: Merge branch 'master' into paintlayerclipper Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp ('k') | third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp

diff --git a/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp b/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp

index f2e106bf825a08e3a09db0ab7131ffb9d3746b90..97c86a90bda984049055e0b145fb3ff3098e1256 100644

--- a/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp

+++ b/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp

@@ -78,18 +78,18 @@ void PaintPropertyTreeBuilderTest::TearDown() {

#define CHECK_VISUAL_RECT(expected, sourceLayoutObject, ancestorLayoutObject, \

slopFactor) \

do { \

- GeometryMapper geometryMapper; \

+ std::unique_ptr<GeometryMapper> geometryMapper = GeometryMapper::create(); \

LayoutRect source((sourceLayoutObject)->localVisualRect()); \

source.moveBy((sourceLayoutObject)->paintOffset()); \

const auto& contentsProperties = \

*(ancestorLayoutObject)->paintProperties()->contentsProperties(); \

LayoutRect actual = LayoutRect( \

geometryMapper \

- .sourceToDestinationVisualRect(FloatRect(source), \

- *(sourceLayoutObject) \

- ->paintProperties() \

- ->localBorderBoxProperties(), \

- contentsProperties) \

+ ->sourceToDestinationVisualRect(FloatRect(source), \

+ *(sourceLayoutObject) \

+ ->paintProperties() \

+ ->localBorderBoxProperties(), \

+ contentsProperties) \

.rect()); \

actual.moveBy(-(ancestorLayoutObject)->paintOffset()); \

EXPECT_EQ(expected, actual) \