Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 2671073002: [Mac] Fullscreen layout issues (Closed)

Created:
3 years, 10 months ago by spqchan
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews, dcheng, mac-reviews_chromium.org
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

[Mac] Fullscreen layout issues - Fixed the incorrect y offset for tab detached windows in fullscreen - Fixed the layout issue with the infobar in fullscreen BUG=670445, 678204 Review-Url: https://codereview.chromium.org/2666213003 Cr-Commit-Position: refs/heads/master@{#447804} (cherry picked from commit a7140be113cefff6413d285e9bce20b513f52686) Review-Url: https://codereview.chromium.org/2671073002 . Cr-Commit-Position: refs/branch-heads/2987@{#300} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/9045f614d43726ac315078312899f4973db5be64

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -17 lines) Patch
M chrome/browser/ui/cocoa/browser_window_controller.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller_private.mm View 3 chunks +15 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_controller.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_controller.mm View 3 chunks +2 lines, -10 lines 0 comments Download
M chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_controller_unittest.mm View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_strip_drag_controller.mm View 1 chunk +5 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_window_controller.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_window_controller.mm View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
spqchan
3 years, 10 months ago (2017-02-03 21:33:02 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9045f614d43726ac315078312899f4973db5be64.

Powered by Google App Engine
This is Rietveld 408576698