Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(797)

Unified Diff: chrome/browser/ui/cocoa/tabs/tab_strip_drag_controller.mm

Issue 2671073002: [Mac] Fullscreen layout issues (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/tabs/tab_strip_drag_controller.mm
diff --git a/chrome/browser/ui/cocoa/tabs/tab_strip_drag_controller.mm b/chrome/browser/ui/cocoa/tabs/tab_strip_drag_controller.mm
index f06e1d1a64b4b5b434df66ea89ab1d6784ba4b12..2e6e3378486d30d0dd24926ca5f166517cc8b252 100644
--- a/chrome/browser/ui/cocoa/tabs/tab_strip_drag_controller.mm
+++ b/chrome/browser/ui/cocoa/tabs/tab_strip_drag_controller.mm
@@ -348,9 +348,13 @@ static BOOL PointIsInsideView(NSPoint screenPoint, NSView* view) {
tearProgress = sqrtf(MAX(MIN(tearProgress, 1.0), 0.0));
// Move the dragged window to the right place on the screen.
+ // TODO(spqchan): Write a test to check if the window is at the right place.
+ // See http://crbug.com/687647.
NSPoint origin = sourceWindowFrame_.origin;
origin.x += (thisPoint.x - dragOrigin_.x);
- origin.y += (thisPoint.y - dragOrigin_.y);
+ origin.y +=
+ (thisPoint.y - dragOrigin_.y) +
+ ([sourceController_ menubarOffset] + [sourceController_ menubarHeight]);
if (tearProgress < 1) {
// If the tear animation is not complete, call back to ourself with the

Powered by Google App Engine
This is Rietveld 408576698