Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issue 2666213003: [Mac] Fullscreen layout issues (Closed)

Created:
3 years, 10 months ago by spqchan
Modified:
3 years, 10 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, dcheng, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] Fullscreen layout issues - Fixed the incorrect y offset for tab detached windows in fullscreen - Fixed the layout issue with the infobar in fullscreen BUG=670445, 678204 Review-Url: https://codereview.chromium.org/2666213003 Cr-Commit-Position: refs/heads/master@{#447804} Committed: https://chromium.googlesource.com/chromium/src/+/a7140be113cefff6413d285e9bce20b513f52686

Patch Set 1 #

Patch Set 2 : Added a comment #

Patch Set 3 : Fixed test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -17 lines) Patch
M chrome/browser/ui/cocoa/browser_window_controller.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller_private.mm View 3 chunks +15 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_controller.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_controller.mm View 3 chunks +2 lines, -10 lines 0 comments Download
M chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_controller_unittest.mm View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_strip_drag_controller.mm View 1 1 chunk +5 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_window_controller.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_window_controller.mm View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 25 (20 generated)
spqchan
PTAL, thanks!
3 years, 10 months ago (2017-02-02 17:37:11 UTC) #18
Robert Sesek
lgtm
3 years, 10 months ago (2017-02-02 18:22:52 UTC) #19
spqchan
On 2017/02/02 18:22:52, Robert Sesek wrote: > lgtm thanks!
3 years, 10 months ago (2017-02-02 18:31:55 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2666213003/60001
3 years, 10 months ago (2017-02-02 18:33:26 UTC) #22
commit-bot: I haz the power
3 years, 10 months ago (2017-02-02 18:40:02 UTC) #25
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/a7140be113cefff6413d285e9bce...

Powered by Google App Engine
This is Rietveld 408576698