chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_controller_unittest.mm - Issue 2671073002: [Mac] Fullscreen layout issues

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_controller_unittest.mm

Issue 2671073002: [Mac] Fullscreen layout issues (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_controller.mm ('k') | chrome/browser/ui/cocoa/tabs/tab_strip_drag_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_controller_unittest.mm

diff --git a/chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_controller_unittest.mm b/chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_controller_unittest.mm

index b731b8b64342614265b8a8f911ea06bb54571af8..152b6185ea57ade43e412f970e40e09c62fc622c 100644

--- a/chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_controller_unittest.mm

+++ b/chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_controller_unittest.mm

@@ -93,12 +93,14 @@ class FullscreenToolbarControllerTest : public testing::Test {

void SetUp() override {

BOOL yes = YES;

BOOL no = NO;

+ CGFloat menubarHeight = 22;

bwc_ = [OCMockObject mockForClass:[BrowserWindowController class]];

[[[bwc_ stub] andReturnValue:OCMOCK_VALUE(yes)]

isKindOfClass:[BrowserWindowController class]];

[[[bwc_ stub] andReturnValue:OCMOCK_VALUE(yes)] isInAppKitFullscreen];

[[[bwc_ stub] andReturnValue:OCMOCK_VALUE(no)] isInImmersiveFullscreen];

+ [[[bwc_ stub] andReturnValue:OCMOCK_VALUE(menubarHeight)] menubarHeight];

[[bwc_ stub] layoutSubviews];

controller_.reset(

@@ -127,8 +129,7 @@ class FullscreenToolbarControllerTest : public testing::Test {

void CheckLayout(CGFloat toolbarFraction, CGFloat menubarFraction) {

FullscreenToolbarLayout layout = [controller_ computeLayout];

EXPECT_EQ(toolbarFraction, layout.toolbarFraction);

- EXPECT_EQ(menubarFraction * [controller_ toolbarVerticalOffset],

- layout.menubarOffset);

+ EXPECT_EQ(menubarFraction * -[bwc_ menubarHeight], layout.menubarOffset);

}

// A mock BrowserWindowController object.