Handle invalid URIs in summaries.

Handle invalid URIs in summaries.

We record all URIs, including invalid, into unlinked summaries.
We still record even invalid URIs as dependencies.
But handle invalid URIs as empty units and libraries.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/6b9f9b7164303a7cc97228d5e2b5b984676aa6a1

[Brian Wilkerson, 2017-02-01 21:02:10]

lgtm

https://codereview.chromium.org/2669863003/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/uri.dart (right):

https://codereview.chromium.org/2669863003/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/uri.dart:8: bool isValidUri(String uriStr) {
I can't see any uses of this function (probably just missing some), but there
are a lot of "on FormatException" wrappers in the code.

https://codereview.chromium.org/2669863003/diff/1/pkg/analyzer/test/src/summa...
File pkg/analyzer/test/src/summary/summarize_ast_test.dart (right):

https://codereview.chromium.org/2669863003/diff/1/pkg/analyzer/test/src/summa...
pkg/analyzer/test/src/summary/summarize_ast_test.dart:171: } on FormatException
{}
Comment explaining why we don't care about the exception?

[scheglov, 2017-02-01 21:08:48]

https://codereview.chromium.org/2669863003/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/uri.dart (right):

https://codereview.chromium.org/2669863003/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/uri.dart:8: bool isValidUri(String uriStr) {
On 2017/02/01 21:02:10, Brian Wilkerson wrote:
> I can't see any uses of this function (probably just missing some), but there
> are a lot of "on FormatException" wrappers in the code.

You're right, we don't use it.
I will remove the file.

https://codereview.chromium.org/2669863003/diff/1/pkg/analyzer/test/src/summa...
File pkg/analyzer/test/src/summary/summarize_ast_test.dart (right):

https://codereview.chromium.org/2669863003/diff/1/pkg/analyzer/test/src/summa...
pkg/analyzer/test/src/summary/summarize_ast_test.dart:171: } on FormatException
{}
On 2017/02/01 21:02:10, Brian Wilkerson wrote:
> Comment explaining why we don't care about the exception?

I made a tweak - we now store an empty unlinked unit.

[Paul Berry, 2017-02-01 21:28:48]

lgtm

[scheglov, 2017-02-01 21:35:02]

Description was changed from

==========
Handle invalid URIs in summaries.

We record all URIs, including invalid, into unlinked summaries.
We still record even invalid URIs as dependencies.
But handle invalid URIs as empty units and libraries.

R=brianwilkerson@google.com, paulberry@google.com
BUG=
==========

to

==========
Handle invalid URIs in summaries.

We record all URIs, including invalid, into unlinked summaries.
We still record even invalid URIs as dependencies.
But handle invalid URIs as empty units and libraries.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/6b9f9b7164303a7cc97228d5e2b5b984676aa6a1
==========

[scheglov, 2017-02-01 21:35:03]

Committed patchset #2 (id:20001) manually as
6b9f9b7164303a7cc97228d5e2b5b984676aa6a1 (presubmit successful).