Handle invalid URIs in summaries.

pkg/analyzer/lib/src/summary/link.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * This library is capable of producing linked summaries from unlinked
  * ones (or prelinked ones).  It functions by building a miniature
  * element model to represent the contents of the summaries, and then
  * scanning the element model to gather linked information and adding
  * it to the summary data structures.
@@ skipping 128 matching lines @@
  * The libraries are prelinked, and a map is returned whose keys are the URIs of
  * the libraries in this build unit, and whose values are the corresponding
  * [LinkedLibraryBuilder]s.
  */
 Map<String, LinkedLibraryBuilder> setupForLink(Set<String> libraryUris,
     GetUnitCallback getUnit, GetDeclaredVariable getDeclaredVariable) {
   Map<String, LinkedLibraryBuilder> linkedLibraries =
       <String, LinkedLibraryBuilder>{};
   for (String absoluteUri in libraryUris) {
     Uri uri = Uri.parse(absoluteUri);
-    UnlinkedUnit getRelativeUnit(String relativeUri) =>
-        getUnit(resolveRelativeUri(uri, Uri.parse(relativeUri)).toString());
+
+    UnlinkedUnit getRelativeUnit(String relativeUriStr) {
+      Uri relativeUri;
+      try {
+        relativeUri = Uri.parse(relativeUriStr);
+      } on FormatException {
+        return new UnlinkedUnitBuilder();
+      }
+      return getUnit(resolveRelativeUri(uri, relativeUri).toString());
+    }
+
     linkedLibraries[absoluteUri] = prelink(
         getUnit(absoluteUri),
         getRelativeUnit,
         (String relativeUri) => getRelativeUnit(relativeUri)?.publicNamespace,
         getDeclaredVariable);
   }
   return linkedLibraries;
 }
 
 /**
@@ skipping 3144 matching lines @@
   /**
    * Get the [UnlinkedUnit] for the defining compilation unit of this library.
    */
   UnlinkedUnit get definingUnlinkedUnit =>
       _definingUnlinkedUnit ??= _linker.getUnit(_absoluteUri.toString());
 
   @override
   Element get enclosingElement => null;
 
   @override
-  List<LibraryElementForLink> get exportedLibraries => _exportedLibraries ??=
-      _linkedLibrary.exportDependencies.map(_getDependency).toList();
+  List<LibraryElementForLink> get exportedLibraries =>
+      _exportedLibraries ??= _linkedLibrary.exportDependencies
+          .map(_getDependency)
+          .where((library) => library != null)
+          .toList();
 
   @override
   String get identifier => _absoluteUri.toString();
 
   @override
   List<LibraryElementForLink> get importedLibraries => _importedLibraries ??=
       _linkedLibrary.importDependencies.map(_getDependency).toList();
 
   @override
   bool get isDartAsync => _absoluteUri.toString() == 'dart:async';
@@ skipping 14 matching lines @@
 
   @override
   List<UnitElement> get units {
     if (_units == null) {
       UnlinkedUnit definingUnit = definingUnlinkedUnit;
       _units = <UnitElement>[
         _makeUnitElement(definingUnit, 0, _absoluteUri.toString())
       ];
       int numParts = definingUnit.parts.length;
       for (int i = 0; i < numParts; i++) {
-        // TODO(paulberry): make sure we handle the case where Uri.parse fails.
         // TODO(paulberry): make sure we handle the case where
         // resolveRelativeUri fails.
+        String partRelativeUriStr = definingUnit.publicNamespace.parts[i];
+
+        Uri partRelativeUri;
+        try {
+          partRelativeUri = Uri.parse(partRelativeUriStr);
+        } on FormatException {
+          continue;
+        }
+
         String partAbsoluteUri = resolveRelativeUri(
-                _absoluteUri, Uri.parse(definingUnit.publicNamespace.parts[i]))
+                _absoluteUri, partRelativeUri)
             .toString();
         UnlinkedUnit partUnit = _linker.getUnit(partAbsoluteUri);
         _units.add(_makeUnitElement(
             partUnit ?? new UnlinkedUnitBuilder(), i + 1, partAbsoluteUri));
       }
     }
     return _units;
   }
 
   /**
@@ skipping 22 matching lines @@
 
   @override
   String toString() => _absoluteUri.toString();
 
   /**
    * Return the [LibraryElement] corresponding to the given dependency [index].
    */
   LibraryElementForLink _getDependency(int index) {
     LibraryElementForLink result = _dependencies[index];
     if (result == null) {
-      String relativeUri = _linkedLibrary.dependencies[index].uri;
-      Uri absoluteUri = relativeUri.isEmpty
+      String relativeUriStr = _linkedLibrary.dependencies[index].uri;
+
+      Uri relativeUri;
+      try {
+        relativeUri = Uri.parse(relativeUriStr);
+      } on FormatException {
+        return null;
+      }
+
+      Uri absoluteUri = relativeUriStr.isEmpty
           ? _absoluteUri
-          : resolveRelativeUri(_absoluteUri, Uri.parse(relativeUri));
+          : resolveRelativeUri(_absoluteUri, relativeUri);
       result = _linker.getLibrary(absoluteUri);
       _dependencies[index] = result;
     }
     return result;
   }
 
   /**
    * Create a [UnitElement] for one of the library's compilation
    * units.
    */
@@ skipping 1592 matching lines @@
    * there are no type parameters in scope.
    */
   TypeParameterizedElementMixin get _typeParameterContext;
 
   @override
   noSuchMethod(Invocation invocation) => super.noSuchMethod(invocation);
 
   @override
   String toString() => '$enclosingElement.$name';
 }