Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Unified Diff: pkg/analyzer/test/src/summary/prelinker_test.dart

Issue 2669863003: Handle invalid URIs in summaries. (Closed)
Patch Set: Remove uri.dart, tweak for summarize_ast_test. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/test/src/summary/prelinker_test.dart
diff --git a/pkg/analyzer/test/src/summary/prelinker_test.dart b/pkg/analyzer/test/src/summary/prelinker_test.dart
index 1fcc9bc07c83a9aaf0e7186bf0c471cbf52dd129..7d595604bd448e2aebe1c86eb05958dfaebbcde6 100644
--- a/pkg/analyzer/test/src/summary/prelinker_test.dart
+++ b/pkg/analyzer/test/src/summary/prelinker_test.dart
@@ -5,6 +5,7 @@
library analyzer.test.src.summary.prelinker_test;
import 'package:analyzer/src/generated/utilities_dart.dart';
+import 'package:analyzer/src/summary/format.dart';
import 'package:analyzer/src/summary/idl.dart';
import 'package:analyzer/src/summary/prelink.dart';
import 'package:test_reflective_loader/test_reflective_loader.dart';
@@ -35,10 +36,16 @@ class PrelinkerTest extends LinkedSummarizeAstTest {
void serializeLibraryText(String text, {bool allowErrors: false}) {
super.serializeLibraryText(text, allowErrors: allowErrors);
- UnlinkedUnit getPart(String relativeUri) {
+ UnlinkedUnit getPart(String relativeUriStr) {
+ Uri relativeUri;
+ try {
+ relativeUri = Uri.parse(relativeUriStr);
+ } on FormatException {
+ return new UnlinkedUnitBuilder();
+ }
+
String absoluteUri =
- resolveRelativeUri(linkerInputs.testDartUri, Uri.parse(relativeUri))
- .toString();
+ resolveRelativeUri(linkerInputs.testDartUri, relativeUri).toString();
return linkerInputs.getUnit(absoluteUri);
}
« no previous file with comments | « pkg/analyzer/test/src/dart/analysis/driver_test.dart ('k') | pkg/analyzer/test/src/summary/resynthesize_ast_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698