Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: pkg/analyzer/test/src/summary/summarize_ast_test.dart

Issue 2669863003: Handle invalid URIs in summaries. (Closed)
Patch Set: Remove uri.dart, tweak for summarize_ast_test. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/test/src/summary/summarize_ast_test.dart
diff --git a/pkg/analyzer/test/src/summary/summarize_ast_test.dart b/pkg/analyzer/test/src/summary/summarize_ast_test.dart
index 932e1fcddbe809f5bae3dfbb86b0fdd5dede0e24..4105d3224f29e934937fcfc03d2b9a7752324231 100644
--- a/pkg/analyzer/test/src/summary/summarize_ast_test.dart
+++ b/pkg/analyzer/test/src/summary/summarize_ast_test.dart
@@ -153,14 +153,21 @@ abstract class LinkedSummarizeAstTest extends SummaryLinkerTest
expect(linked, isNotNull);
validateLinkedLibrary(linked);
unlinkedUnits = <UnlinkedUnit>[linkerInputs.unlinkedDefiningUnit];
- for (String relativeUri
+ for (String relativeUriStr
in linkerInputs.unlinkedDefiningUnit.publicNamespace.parts) {
+ Uri relativeUri;
+ try {
+ relativeUri = Uri.parse(relativeUriStr);
+ } on FormatException {
+ unlinkedUnits.add(new UnlinkedUnitBuilder());
+ continue;
+ }
+
UnlinkedUnit unit = uriToUnit[
- resolveRelativeUri(linkerInputs.testDartUri, Uri.parse(relativeUri))
- .toString()];
+ resolveRelativeUri(linkerInputs.testDartUri, relativeUri).toString()];
if (unit == null) {
if (!allowMissingFiles) {
- fail('Test referred to unknown unit $relativeUri');
+ fail('Test referred to unknown unit $relativeUriStr');
}
} else {
unlinkedUnits.add(unit);
« no previous file with comments | « pkg/analyzer/test/src/summary/resynthesize_common.dart ('k') | pkg/analyzer/test/src/summary/summary_common.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698