Handle invalid URIs in summaries.

pkg/analyzer/test/src/summary/summarize_ast_test.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library analyzer.test.src.summary.summarize_ast_test;
 
 import 'package:analyzer/analyzer.dart';
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/ast/token.dart';
 import 'package:analyzer/error/listener.dart';
@@ skipping 135 matching lines @@
     linkerInputs = createLinkerInputs(text);
     linked = link(
         linkerInputs.linkedLibraries,
         linkerInputs.getDependency,
         linkerInputs.getUnit,
         (name) => null,
         strongMode)[linkerInputs.testDartUri.toString()];
     expect(linked, isNotNull);
     validateLinkedLibrary(linked);
     unlinkedUnits = <UnlinkedUnit>[linkerInputs.unlinkedDefiningUnit];
-    for (String relativeUri
+    for (String relativeUriStr
         in linkerInputs.unlinkedDefiningUnit.publicNamespace.parts) {
-      UnlinkedUnit unit = uriToUnit[
-          resolveRelativeUri(linkerInputs.testDartUri, Uri.parse(relativeUri))
-              .toString()];
-      if (unit == null) {
-        if (!allowMissingFiles) {
-          fail('Test referred to unknown unit $relativeUri');
+      UnlinkedUnit unit;
+      try {
+        Uri relativeUri = Uri.parse(relativeUriStr);
+        unit = uriToUnit[
+            resolveRelativeUri(linkerInputs.testDartUri, relativeUri)
+                .toString()];
+        if (unit == null) {
+          if (!allowMissingFiles) {
+            fail('Test referred to unknown unit $relativeUriStr');
+          }
+        } else {
+          unlinkedUnits.add(unit);
         }
-      } else {
-        unlinkedUnits.add(unit);
-      }
+      } on FormatException {}

[Brian Wilkerson, 2017/02/01 21:02:10]

Comment explaining why we don't care about the exception?

[scheglov, 2017/02/01 21:08:48]

I made a tweak - we now store an empty unlinked unit.

     }
   }
 
   test_class_no_superclass() {
     UnlinkedClass cls = serializeClassText('part of dart.core; class Object {}',
         className: 'Object');
     expect(cls.supertype, isNull);
     expect(cls.hasNoSupertype, isTrue);
   }
 }
@@ skipping 158 matching lines @@
    * passed to [addNamedSource].
    */
   Map<String, UnlinkedUnitBuilder> uriToUnit = <String, UnlinkedUnitBuilder>{};
 
   /**
    * Information about summaries to be included in the link process.
    */
   SummaryDataStore summaryDataStore =
       new SummaryDataStore([], recordDependencyInfo: true);
 }