Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(636)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2669353002: Stop using Element.computeNode() in refactorings and fixes. (Closed)

Created:
3 years, 10 months ago by scheglov
Modified:
3 years, 10 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : documentation comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+331 lines, -96 lines) Patch
M pkg/analysis_server/lib/plugin/edit/fix/fix_dart.dart View 3 chunks +11 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/analysis_server.dart View 1 4 chunks +33 lines, -17 lines 0 comments Download
M pkg/analysis_server/lib/src/edit/edit_domain.dart View 13 chunks +19 lines, -19 lines 0 comments Download
M pkg/analysis_server/lib/src/services/correction/fix_internal.dart View 9 chunks +16 lines, -9 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/convert_getter_to_method.dart View 5 chunks +10 lines, -6 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/convert_method_to_getter.dart View 6 chunks +10 lines, -8 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/inline_local.dart View 4 chunks +4 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/inline_method.dart View 5 chunks +7 lines, -6 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/refactoring.dart View 7 chunks +17 lines, -17 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/rename_constructor.dart View 4 chunks +8 lines, -4 lines 0 comments Download
M pkg/analysis_server/test/services/correction/fix_test.dart View 3 chunks +7 lines, -1 line 0 comments Download
M pkg/analysis_server/test/services/refactoring/abstract_refactoring.dart View 3 chunks +6 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/abstract_rename.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/refactoring/convert_getter_to_method_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/test/services/refactoring/convert_method_to_getter_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/refactoring/inline_local_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/test/services/refactoring/inline_method_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/refactoring/rename_constructor_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
A pkg/analyzer/lib/src/dart/analysis/ast_provider_context.dart View 1 1 chunk +31 lines, -0 lines 0 comments Download
A pkg/analyzer/lib/src/dart/analysis/ast_provider_driver.dart View 1 1 chunk +107 lines, -0 lines 0 comments Download
A pkg/analyzer/lib/src/dart/element/ast_provider.dart View 1 1 chunk +36 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
3 years, 10 months ago (2017-02-02 20:59:46 UTC) #1
Brian Wilkerson
lgtm https://codereview.chromium.org/2669353002/diff/1/pkg/analyzer/lib/src/dart/element/ast_provider.dart File pkg/analyzer/lib/src/dart/element/ast_provider.dart (right): https://codereview.chromium.org/2669353002/diff/1/pkg/analyzer/lib/src/dart/element/ast_provider.dart#newcode11 pkg/analyzer/lib/src/dart/element/ast_provider.dart:11: * TODO(scheglov) document Do you want to do ...
3 years, 10 months ago (2017-02-02 21:07:02 UTC) #2
scheglov
https://codereview.chromium.org/2669353002/diff/1/pkg/analyzer/lib/src/dart/element/ast_provider.dart File pkg/analyzer/lib/src/dart/element/ast_provider.dart (right): https://codereview.chromium.org/2669353002/diff/1/pkg/analyzer/lib/src/dart/element/ast_provider.dart#newcode11 pkg/analyzer/lib/src/dart/element/ast_provider.dart:11: * TODO(scheglov) document On 2017/02/02 21:07:01, Brian Wilkerson wrote: ...
3 years, 10 months ago (2017-02-02 21:08:03 UTC) #3
scheglov
3 years, 10 months ago (2017-02-03 01:24:40 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
f600f5f9de9b52fd63e929d9402fef45e287a0eb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698