Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: pkg/analysis_server/lib/src/services/refactoring/rename_constructor.dart

Issue 2669353002: Stop using Element.computeNode() in refactorings and fixes. (Closed)
Patch Set: documentation comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/services/refactoring/rename_constructor.dart
diff --git a/pkg/analysis_server/lib/src/services/refactoring/rename_constructor.dart b/pkg/analysis_server/lib/src/services/refactoring/rename_constructor.dart
index cb9d88da82bc126af48ebad2d772e8c0a8fd0008..cf6c2799663d1da165fa30dd4083d97a70d612ed 100644
--- a/pkg/analysis_server/lib/src/services/refactoring/rename_constructor.dart
+++ b/pkg/analysis_server/lib/src/services/refactoring/rename_constructor.dart
@@ -19,6 +19,7 @@ import 'package:analysis_server/src/services/search/search_engine.dart';
import 'package:analysis_server/src/services/search/search_engine_internal.dart';
import 'package:analyzer/dart/ast/ast.dart';
import 'package:analyzer/dart/element/element.dart';
+import 'package:analyzer/src/dart/element/ast_provider.dart';
import 'package:analyzer/src/generated/java_core.dart';
import 'package:analyzer/src/generated/source.dart';
@@ -26,8 +27,10 @@ import 'package:analyzer/src/generated/source.dart';
* A [Refactoring] for renaming [ConstructorElement]s.
*/
class RenameConstructorRefactoringImpl extends RenameRefactoringImpl {
+ final AstProvider astProvider;
+
RenameConstructorRefactoringImpl(
- SearchEngine searchEngine, ConstructorElement element)
+ SearchEngine searchEngine, this.astProvider, ConstructorElement element)
: super(searchEngine, element);
@override
@@ -61,7 +64,7 @@ class RenameConstructorRefactoringImpl extends RenameRefactoringImpl {
List<SourceReference> references = getSourceReferences(matches);
// append declaration
if (element.isSynthetic) {
- _replaceSynthetic();
+ await _replaceSynthetic();
} else {
references.add(_createDeclarationReference());
}
@@ -107,9 +110,10 @@ class RenameConstructorRefactoringImpl extends RenameRefactoringImpl {
true));
}
- void _replaceSynthetic() {
+ Future<Null> _replaceSynthetic() async {
ClassElement classElement = element.enclosingElement;
- ClassDeclaration classNode = classElement.computeNode();
+ ClassDeclaration classNode =
+ await astProvider.getResolvedNodeForElement(classElement);
CorrectionUtils utils = new CorrectionUtils(classNode.parent);
ClassMemberLocation location =
utils.prepareNewConstructorLocation(classNode);

Powered by Google App Engine
This is Rietveld 408576698