Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: pkg/analysis_server/lib/src/services/refactoring/inline_local.dart

Issue 2669353002: Stop using Element.computeNode() in refactorings and fixes. (Closed)
Patch Set: documentation comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/services/refactoring/inline_local.dart
diff --git a/pkg/analysis_server/lib/src/services/refactoring/inline_local.dart b/pkg/analysis_server/lib/src/services/refactoring/inline_local.dart
index 141eb8a3cb2360736f8c0c0169e8efd776a90b11..362080afe059edbdee8fa5c63f0bdc7bb2c8ec76 100644
--- a/pkg/analysis_server/lib/src/services/refactoring/inline_local.dart
+++ b/pkg/analysis_server/lib/src/services/refactoring/inline_local.dart
@@ -17,6 +17,7 @@ import 'package:analyzer/dart/ast/ast.dart';
import 'package:analyzer/dart/ast/token.dart';
import 'package:analyzer/dart/element/element.dart';
import 'package:analyzer/src/dart/ast/utilities.dart';
+import 'package:analyzer/src/dart/element/ast_provider.dart';
import 'package:analyzer/src/generated/java_core.dart';
import 'package:analyzer/src/generated/source.dart';
@@ -26,6 +27,7 @@ import 'package:analyzer/src/generated/source.dart';
class InlineLocalRefactoringImpl extends RefactoringImpl
implements InlineLocalRefactoring {
final SearchEngine searchEngine;
+ final AstProvider astProvider;
final CompilationUnit unit;
final int offset;
CompilationUnitElement unitElement;
@@ -35,7 +37,7 @@ class InlineLocalRefactoringImpl extends RefactoringImpl
VariableDeclaration _variableNode;
List<SearchMatch> _references;
- InlineLocalRefactoringImpl(this.searchEngine, this.unit, this.offset) {
+ InlineLocalRefactoringImpl(this.searchEngine, this.astProvider, this.unit, this.offset) {
unitElement = unit.element;
utils = new CorrectionUtils(unit);
}
@@ -75,7 +77,7 @@ class InlineLocalRefactoringImpl extends RefactoringImpl
Element element = offsetNode.staticElement;
if (element is LocalVariableElement) {
_variableElement = element;
- _variableNode = element.computeNode();
+ _variableNode = await astProvider.getResolvedNodeForElement(element);
}
}
}

Powered by Google App Engine
This is Rietveld 408576698