Stop using Element.computeNode() in refactorings and fixes.

pkg/analysis_server/lib/src/edit/edit_domain.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library edit.domain;
 
 import 'dart:async';
 
 import 'package:analysis_server/plugin/edit/assist/assist_core.dart';
 import 'package:analysis_server/plugin/edit/assist/assist_dart.dart';
@@ skipping 11 matching lines @@
 import 'package:analysis_server/src/services/correction/sort_members.dart';
 import 'package:analysis_server/src/services/correction/status.dart';
 import 'package:analysis_server/src/services/refactoring/refactoring.dart';
 import 'package:analysis_server/src/services/search/search_engine.dart';
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/ast/standard_resolution_map.dart';
 import 'package:analyzer/dart/element/element.dart';
 import 'package:analyzer/error/error.dart' as engine;
 import 'package:analyzer/file_system/file_system.dart';
 import 'package:analyzer/src/dart/analysis/driver.dart';
+import 'package:analyzer/src/dart/element/ast_provider.dart';
 import 'package:analyzer/src/dart/scanner/scanner.dart' as engine;
 import 'package:analyzer/src/error/codes.dart' as engine;
 import 'package:analyzer/src/generated/engine.dart' as engine;
 import 'package:analyzer/src/generated/parser.dart' as engine;
 import 'package:analyzer/src/generated/source.dart';
 import 'package:analyzer/task/dart.dart';
 import 'package:dart_style/dart_style.dart';
 
 int test_resetCount = 0;
 
@@ skipping 146 matching lines @@
         CompilationUnit unit = result.unit;
         LineInfo lineInfo = result.lineInfo;
         int requestLine = lineInfo.getLocation(offset).lineNumber;
         for (engine.AnalysisError error in result.errors) {
           int errorLine = lineInfo.getLocation(error.offset).lineNumber;
           if (errorLine == requestLine) {
             var context = new _DartFixContextImpl(
                 server.resourceProvider,
                 result.driver.getTopLevelNameDeclarations,
                 resolutionMap.elementDeclaredByCompilationUnit(unit).context,
+                server.getAstProvider(file),
                 unit,
                 error);
             List<Fix> fixes =
                 await new DefaultFixContributor().internalComputeFixes(context);
             if (fixes.isNotEmpty) {
               fixes.sort(Fix.SORT_BY_RELEVANCE);
               AnalysisError serverError =
                   newAnalysisError_fromEngine(lineInfo, error);
               AnalysisErrorFixes errorFixes =
                   new AnalysisErrorFixes(serverError);
@@ skipping 205 matching lines @@
       kinds.add(RefactoringKind.EXTRACT_LOCAL_VARIABLE);
       kinds.add(RefactoringKind.EXTRACT_METHOD);
     }
     // check elements
     {
       Element element = await server.getElementAtOffset(file, offset);
       if (element != null) {
         // try CONVERT_METHOD_TO_GETTER
         if (element is ExecutableElement) {
           Refactoring refactoring = new ConvertMethodToGetterRefactoring(
-              searchEngine, _getResolvedUnit, element);
+              searchEngine, server.getAstProvider(file), element);
           RefactoringStatus status = await refactoring.checkInitialConditions();
           if (!status.hasFatalError) {
             kinds.add(RefactoringKind.CONVERT_METHOD_TO_GETTER);
           }
         }
         // try RENAME
         {
-          RenameRefactoring renameRefactoring =
-              new RenameRefactoring(searchEngine, element);
+          RenameRefactoring renameRefactoring = new RenameRefactoring(
+              searchEngine, server.getAstProvider(file), element);
           if (renameRefactoring != null) {
             kinds.add(RefactoringKind.RENAME);
           }
         }
       }
     }
     // respond
     var result = new EditGetAvailableRefactoringsResult(kinds);
     server.sendResponse(result.toResponse(request.id));
   }
 
   Response _getRefactoring(Request request) {
     if (searchEngine == null) {
       return new Response.noIndexGenerated(request);
     }
     if (refactoringManager.hasPendingRequest) {
       refactoringManager.cancel();
       _newRefactoringManager();
     }
     refactoringManager.getRefactoring(request);
     return Response.DELAYED_RESPONSE;
   }
 
-  Future<CompilationUnit> _getResolvedUnit(Element element) {
-    String path = element.source.fullName;
-    return server.getResolvedCompilationUnit(path);
-  }
-
   /**
    * Initializes [refactoringManager] with a new instance.
    */
   void _newRefactoringManager() {
-    refactoringManager =
-        new _RefactoringManager(server, _getResolvedUnit, searchEngine);
+    refactoringManager = new _RefactoringManager(server, searchEngine);
   }
 
   static int _getNumberOfScanParseErrors(List<engine.AnalysisError> errors) {
     int numScanParseErrors = 0;
     for (engine.AnalysisError error in errors) {
       if (error.errorCode is engine.ScannerErrorCode ||
           error.errorCode is engine.ParserErrorCode) {
         numScanParseErrors++;
       }
     }
@@ skipping 32 matching lines @@
   @override
   final ResourceProvider resourceProvider;
 
   @override
   final GetTopLevelDeclarations getTopLevelDeclarations;
 
   @override
   final engine.AnalysisContext analysisContext;
 
   @override
+  final AstProvider astProvider;
+
+  @override
   final CompilationUnit unit;
 
   @override
   final engine.AnalysisError error;
 
   _DartFixContextImpl(this.resourceProvider, this.getTopLevelDeclarations,
-      this.analysisContext, this.unit, this.error);
+      this.analysisContext, this.astProvider, this.unit, this.error);
 }
 
 /**
  * An object managing a single [Refactoring] instance.
  *
  * The instance is identified by its kind, file, offset and length.
  * It is initialized when the a set of parameters is given for the first time.
  * All subsequent requests are performed on this [Refactoring] instance.
  *
  * Once new set of parameters is received, the previous [Refactoring] instance
  * is invalidated and a new one is created and initialized.
  */
 class _RefactoringManager {
   static const List<RefactoringProblem> EMPTY_PROBLEM_LIST =
       const <RefactoringProblem>[];
 
   final AnalysisServer server;
-  final GetResolvedUnit getResolvedUnit;
   final SearchEngine searchEngine;
   StreamSubscription subscriptionToReset;
 
   RefactoringKind kind;
   String file;
   int offset;
   int length;
   Refactoring refactoring;
   RefactoringFeedback feedback;
   RefactoringStatus initStatus;
   RefactoringStatus optionsStatus;
   RefactoringStatus finalStatus;
 
   Request request;
   EditGetRefactoringResult result;
 
-  _RefactoringManager(this.server, this.getResolvedUnit, this.searchEngine) {
+  _RefactoringManager(this.server, this.searchEngine) {
     _reset();
   }
 
   /**
    * Returns `true` if a response for the current request has not yet been sent.
    */
   bool get hasPendingRequest => request != null;
 
   bool get _hasFatalError {
     return initStatus.hasFatalError ||
@@ skipping 163 matching lines @@
     // simulate an exception
     if (test_simulateRefactoringException_init) {
       throw 'A simulated refactoring exception - init.';
     }
     // create a new Refactoring instance
     if (kind == RefactoringKind.CONVERT_GETTER_TO_METHOD) {
       Element element = await server.getElementAtOffset(file, offset);
       if (element != null) {
         if (element is ExecutableElement) {
           _resetOnAnalysisStarted();
-          refactoring =
-              new ConvertGetterToMethodRefactoring(searchEngine, element);
+          refactoring = new ConvertGetterToMethodRefactoring(
+              searchEngine, server.getAstProvider(file), element);
         }
       }
     }
     if (kind == RefactoringKind.CONVERT_METHOD_TO_GETTER) {
       Element element = await server.getElementAtOffset(file, offset);
       if (element != null) {
         if (element is ExecutableElement) {
           _resetOnAnalysisStarted();
           refactoring = new ConvertMethodToGetterRefactoring(
-              searchEngine, getResolvedUnit, element);
+              searchEngine, server.getAstProvider(file), element);
         }
       }
     }
     if (kind == RefactoringKind.EXTRACT_LOCAL_VARIABLE) {
       CompilationUnit unit = await server.getResolvedCompilationUnit(file);
       if (unit != null) {
         _resetOnFileResolutionChanged(file);
         refactoring = new ExtractLocalRefactoring(unit, offset, length);
         feedback = new ExtractLocalVariableFeedback(
             <String>[], <int>[], <int>[],
             coveringExpressionOffsets: <int>[],
             coveringExpressionLengths: <int>[]);
       }
     }
     if (kind == RefactoringKind.EXTRACT_METHOD) {
       CompilationUnit unit = await server.getResolvedCompilationUnit(file);
       if (unit != null) {
         _resetOnAnalysisStarted();
         refactoring =
             new ExtractMethodRefactoring(searchEngine, unit, offset, length);
         feedback = new ExtractMethodFeedback(offset, length, '', <String>[],
             false, <RefactoringMethodParameter>[], <int>[], <int>[]);
       }
     }
     if (kind == RefactoringKind.INLINE_LOCAL_VARIABLE) {
       CompilationUnit unit = await server.getResolvedCompilationUnit(file);
       if (unit != null) {
         _resetOnFileResolutionChanged(file);
-        refactoring = new InlineLocalRefactoring(searchEngine, unit, offset);
+        refactoring = new InlineLocalRefactoring(
+            searchEngine, server.getAstProvider(file), unit, offset);
       }
     }
     if (kind == RefactoringKind.INLINE_METHOD) {
       CompilationUnit unit = await server.getResolvedCompilationUnit(file);
       if (unit != null) {
         _resetOnAnalysisStarted();
         refactoring = new InlineMethodRefactoring(
-            searchEngine, getResolvedUnit, unit, offset);
+            searchEngine, server.getAstProvider(file), unit, offset);
       }
     }
     if (kind == RefactoringKind.MOVE_FILE) {
       _resetOnAnalysisStarted();
       ContextSourcePair contextSource = server.getContextSourcePair(file);
       engine.AnalysisContext context = contextSource.context;
       Source source = contextSource.source;
       refactoring = new MoveFileRefactoring(
           server.resourceProvider, searchEngine, context, source, file);
     }
     if (kind == RefactoringKind.RENAME) {
       AstNode node = await server.getNodeAtOffset(file, offset);
       Element element = server.getElementOfNode(node);
       if (node != null && element != null) {
         if (element is FieldFormalParameterElement) {
           element = (element as FieldFormalParameterElement).field;
         }
         // climb from "Class" in "new Class.named()" to "Class.named"
         if (node.parent is TypeName && node.parent.parent is ConstructorName) {
           ConstructorName constructor = node.parent.parent;
           node = constructor;
           element = constructor.staticElement;
         }
         // do create the refactoring
         _resetOnAnalysisStarted();
-        refactoring = new RenameRefactoring(searchEngine, element);
+        refactoring = new RenameRefactoring(
+            searchEngine, server.getAstProvider(file), element);
         feedback =
             new RenameFeedback(node.offset, node.length, 'kind', 'oldName');
       }
     }
     if (refactoring == null) {
       initStatus =
           new RefactoringStatus.fatal('Unable to create a refactoring');
       return;
     }
     // check initial conditions
@@ skipping 142 matching lines @@
     }
     return new RefactoringStatus();
   }
 }
 
 /**
  * [_RefactoringManager] throws instances of this class internally to stop
  * processing in a manager that was reset.
  */
 class _ResetError {}