Stop using Element.computeNode() in refactorings and fixes.

pkg/analysis_server/lib/src/services/refactoring/inline_method.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library services.src.refactoring.inline_method;
 
 import 'dart:async';
 
 import 'package:analysis_server/src/protocol_server.dart' hide Element;
 import 'package:analysis_server/src/services/correction/source_range.dart';
 import 'package:analysis_server/src/services/correction/status.dart';
 import 'package:analysis_server/src/services/correction/strings.dart';
 import 'package:analysis_server/src/services/correction/util.dart';
 import 'package:analysis_server/src/services/refactoring/refactoring.dart';
 import 'package:analysis_server/src/services/refactoring/refactoring_internal.dart';
 import 'package:analysis_server/src/services/search/element_visitors.dart';
 import 'package:analysis_server/src/services/search/hierarchy.dart';
 import 'package:analysis_server/src/services/search/search_engine.dart';
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/ast/visitor.dart';
 import 'package:analyzer/dart/element/element.dart';
 import 'package:analyzer/src/dart/ast/utilities.dart';
+import 'package:analyzer/src/dart/element/ast_provider.dart';
 import 'package:analyzer/src/generated/source.dart';
 import 'package:analyzer/src/generated/utilities_dart.dart';
 
 /**
  * Returns the [SourceRange] to find conflicting locals in.
  */
 SourceRange _getLocalsConflictingRange(AstNode node) {
   // maybe Block
   Block block = node.getAncestor((node) => node is Block);
   if (block != null) {
@@ skipping 156 matching lines @@
   // done
   return result;
 }
 
 /**
  * [InlineMethodRefactoring] implementation.
  */
 class InlineMethodRefactoringImpl extends RefactoringImpl
     implements InlineMethodRefactoring {
   final SearchEngine searchEngine;
-  final GetResolvedUnit getResolvedUnit;
+  final AstProvider astProvider;
   final CompilationUnit unit;
   final int offset;
   _UnitCache _unitCache;
   CorrectionUtils utils;
   SourceChange change;
 
   bool isDeclaration = false;
   bool deleteSource = false;
   bool inlineAll = true;
 
   ExecutableElement _methodElement;
   bool _isAccessor;
   CompilationUnit _methodUnit;
   CorrectionUtils _methodUtils;
   AstNode _methodNode;
   FormalParameterList _methodParameters;
   FunctionBody _methodBody;
   Expression _methodExpression;
   _SourcePart _methodExpressionPart;
   _SourcePart _methodStatementsPart;
   List<_ReferenceProcessor> _referenceProcessors = [];
   Set<FunctionBody> _alreadyMadeAsync = new Set<FunctionBody>();
 
   InlineMethodRefactoringImpl(
-      this.searchEngine, this.getResolvedUnit, this.unit, this.offset) {
-    _unitCache = new _UnitCache(getResolvedUnit, unit);
+      this.searchEngine, this.astProvider, this.unit, this.offset) {
+    _unitCache = new _UnitCache(astProvider, unit);
     utils = new CorrectionUtils(unit);
   }
 
   @override
   String get className {
     if (_methodElement == null) {
       return null;
     }
     Element classElement = _methodElement.enclosingElement;
     if (classElement is ClassElement) {
@@ skipping 546 matching lines @@
     if (ranges == null) {
       ranges = [];
       _variables[element] = ranges;
     }
     range = rangeFromBase(range, _base);
     ranges.add(range);
   }
 }
 
 class _UnitCache {
-  final GetResolvedUnit getResolvedUnit;
+  final AstProvider astProvider;
   final Map<CompilationUnitElement, CompilationUnit> map = {};
 
-  _UnitCache(this.getResolvedUnit, CompilationUnit unit) {
+  _UnitCache(this.astProvider, CompilationUnit unit) {
     map[unit.element] = unit;
   }
 
   Future<CompilationUnit> getUnit(Element element) async {
     Element unitElement =
         element.getAncestor((e) => e is CompilationUnitElement);
     CompilationUnit unit = map[unitElement];
     if (unit == null) {
-      unit = unitElement.unit;
+      unit = await astProvider.getResolvedUnitForElement(element);
       map[unitElement] = unit;
     }
     return unit;
   }
 }
 
 /**
  * A visitor that fills [_SourcePart] with fields, parameters and variables.
  */
 class _VariablesVisitor extends GeneralizingAstVisitor {
@@ skipping 86 matching lines @@
   }
 
   void _addVariable(SimpleIdentifier node) {
     VariableElement variableElement = getLocalVariableElement(node);
     if (variableElement != null) {
       SourceRange nodeRange = rangeNode(node);
       result.addVariable(variableElement, nodeRange);
     }
   }
 }