Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 2667803005: 📰 Remove the NTP_SUGGESTIONS_SECTION_DISMISSAL feature flag (Closed)

Created:
3 years, 10 months ago by dgn
Modified:
3 years, 10 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, noyau+watch_chromium.org, ntp-dev+reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NTP Client] Remove the NTP_SUGGESTIONS_SECTION_DISMISSAL feature flag BUG=687167 Review-Url: https://codereview.chromium.org/2667803005 Cr-Commit-Position: refs/heads/master@{#447499} Committed: https://chromium.googlesource.com/chromium/src/+/1764521fd144201e6dbb5514ad8967b50c035393

Patch Set 1 #

Patch Set 2 : [NTP Client] Remove the NTPSuggestionsFetchMore feature flag #

Patch Set 3 : only NTP_SUGGESTIONS_SECTION_DISMISSAL #

Messages

Total messages: 20 (16 generated)
dgn
PTAL
3 years, 10 months ago (2017-01-31 19:16:28 UTC) #2
Bernhard Bauer
LGTM!
3 years, 10 months ago (2017-01-31 21:55:28 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2667803005/40001
3 years, 10 months ago (2017-02-01 13:12:07 UTC) #17
commit-bot: I haz the power
3 years, 10 months ago (2017-02-01 13:18:03 UTC) #20
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/1764521fd144201e6dbb5514ad89...

Powered by Google App Engine
This is Rietveld 408576698