chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SectionList.java - Issue 2667803005: 📰 Remove the NTP_SUGGESTIONS_SECTION_DISMISSAL feature flag

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SectionList.java

Issue 2667803005: 📰 Remove the NTP_SUGGESTIONS_SECTION_DISMISSAL feature flag (Closed)

Patch Set: only NTP_SUGGESTIONS_SECTION_DISMISSAL Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SectionList.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SectionList.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SectionList.java

index 4d090a9bddd2efbd9a1766a6ee4bf82d8a456bb1..26c56d1e1dcb107dc1704953ddcc2b78eff9c6ec 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SectionList.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SectionList.java

@@ -12,7 +12,6 @@

import org.chromium.chrome.browser.ntp.snippets.CategoryStatus.CategoryStatusEnum;

import org.chromium.chrome.browser.ntp.snippets.SnippetArticle;

import org.chromium.chrome.browser.ntp.snippets.SnippetsBridge;

-import org.chromium.chrome.browser.ntp.snippets.SnippetsConfig;

import org.chromium.chrome.browser.ntp.snippets.SuggestionsSource;

import org.chromium.chrome.browser.offlinepages.OfflinePageBridge;

import org.chromium.chrome.browser.suggestions.SuggestionsRanker;

@@ -222,8 +221,6 @@ private boolean canLoadSuggestions(@CategoryInt int category, @CategoryStatusEnu

@Override

public void dismissSection(SuggestionsSection section) {

- assert SnippetsConfig.isSectionDismissalEnabled();

mUiDelegate.getSuggestionsSource().dismissCategory(section.getCategory());

removeSection(section);

}