chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java - Issue 2667803005: 📰 Remove the NTP_SUGGESTIONS_SECTION_DISMISSAL feature flag

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java

Issue 2667803005: 📰 Remove the NTP_SUGGESTIONS_SECTION_DISMISSAL feature flag (Closed)

Patch Set: only NTP_SUGGESTIONS_SECTION_DISMISSAL Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SectionList.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsConfig.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java

index c085f9fd6fd1b3e2a968e66de51b06a48087d12d..b3eca4047d55eec774e7bd14a082034df83a677c 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java

@@ -15,7 +15,6 @@

import org.chromium.chrome.browser.ntp.snippets.SnippetArticle;

import org.chromium.chrome.browser.ntp.snippets.SnippetArticleViewHolder;

import org.chromium.chrome.browser.ntp.snippets.SnippetsBridge;

-import org.chromium.chrome.browser.ntp.snippets.SnippetsConfig;

import org.chromium.chrome.browser.ntp.snippets.SuggestionsSource;

import org.chromium.chrome.browser.offlinepages.ClientId;

import org.chromium.chrome.browser.offlinepages.OfflinePageBridge;

@@ -468,9 +467,7 @@ public int getCategory() {

* (as opposed to individual items in it).

private Set<Integer> getSectionDismissalRange() {

- if (hasSuggestions() || !SnippetsConfig.isSectionDismissalEnabled()) {

- return Collections.emptySet();

- }

+ if (hasSuggestions()) return Collections.emptySet();

if (!mMoreButton.isVisible()) {

assert getStartingOffsetForChild(mStatus) == 1;