chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java - Issue 2667803005: 📰 Remove the NTP_SUGGESTIONS_SECTION_DISMISSAL feature flag

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java

Issue 2667803005: 📰 Remove the NTP_SUGGESTIONS_SECTION_DISMISSAL feature flag (Closed)

Patch Set: only NTP_SUGGESTIONS_SECTION_DISMISSAL Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsConfig.java ('k') | chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSectionTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java

diff --git a/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java b/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java

index 52125c767656f19f3835df1f30e20824486a8182..6cd872f04ca8a1edaf946964dfcdd7147477f7e5 100644

--- a/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java

+++ b/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java

@@ -50,7 +50,6 @@

import org.chromium.base.ContextUtils;

import org.chromium.base.test.util.Feature;

import org.chromium.chrome.R;

-import org.chromium.chrome.browser.ChromeFeatureList;

import org.chromium.chrome.browser.DisableHistogramsRule;

import org.chromium.chrome.browser.EnableFeatures;

import org.chromium.chrome.browser.ntp.ContextMenuManager;

@@ -822,7 +821,6 @@ public void testSigninPromoDismissal() {

@Test

@Feature({"Ntp"})

- @EnableFeatures(ChromeFeatureList.NTP_SUGGESTIONS_SECTION_DISMISSAL)

public void testAllDismissedVisibility() {

ArgumentCaptor<DestructionObserver> observers =

ArgumentCaptor.forClass(DestructionObserver.class);