Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 2667623002: [Remote suggestions] Clean up variation params in the status service (Closed)

Created:
3 years, 10 months ago by jkrcal
Modified:
3 years, 10 months ago
Reviewers:
Marc Treib
CC:
chromium-reviews, noyau+watch_chromium.org, ntp-dev+reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Remote suggestions] Clean up variation params in the status service This CL removes one variation parameter that is not needed any more. BUG=686778 Review-Url: https://codereview.chromium.org/2667623002 Cr-Commit-Position: refs/heads/master@{#447213} Committed: https://chromium.googlesource.com/chromium/src/+/f7b320544b2f99fe301308420efdb1acf0196838

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -82 lines) Patch
M components/ntp_snippets/remote/remote_suggestions_provider_impl.cc View 1 1 chunk +0 lines, -5 lines 0 comments Download
M components/ntp_snippets/remote/remote_suggestions_provider_impl_unittest.cc View 1 1 chunk +0 lines, -31 lines 0 comments Download
M components/ntp_snippets/remote/remote_suggestions_status_service.h View 2 chunks +0 lines, -3 lines 0 comments Download
M components/ntp_snippets/remote/remote_suggestions_status_service.cc View 2 chunks +1 line, -25 lines 0 comments Download
M components/ntp_snippets/remote/remote_suggestions_status_service_unittest.cc View 1 chunk +0 lines, -18 lines 0 comments Download

Messages

Total messages: 17 (13 generated)
jkrcal
Marc, part 2 of the trilogy!
3 years, 10 months ago (2017-01-30 17:21:29 UTC) #4
Marc Treib
LGTM assuming bots are happy
3 years, 10 months ago (2017-01-31 09:03:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2667623002/20001
3 years, 10 months ago (2017-01-31 10:17:42 UTC) #14
commit-bot: I haz the power
3 years, 10 months ago (2017-01-31 10:21:59 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f7b320544b2f99fe301308420efd...

Powered by Google App Engine
This is Rietveld 408576698