Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(660)

Unified Diff: components/ntp_snippets/remote/remote_suggestions_status_service_unittest.cc

Issue 2667623002: [Remote suggestions] Clean up variation params in the status service (Closed)
Patch Set: Rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/ntp_snippets/remote/remote_suggestions_status_service.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/ntp_snippets/remote/remote_suggestions_status_service_unittest.cc
diff --git a/components/ntp_snippets/remote/remote_suggestions_status_service_unittest.cc b/components/ntp_snippets/remote/remote_suggestions_status_service_unittest.cc
index c24650af8cf6dfebb97b4dd3495049eaf3f47c86..6b6fd7a5900bb0b6ccfef6d2df1afe65bafe16d8 100644
--- a/components/ntp_snippets/remote/remote_suggestions_status_service_unittest.cc
+++ b/components/ntp_snippets/remote/remote_suggestions_status_service_unittest.cc
@@ -40,24 +40,6 @@ class RemoteSuggestionsStatusServiceTest : public ::testing::Test {
variations::testing::VariationParamsManager params_manager_;
};
-TEST_F(RemoteSuggestionsStatusServiceTest, SigninNeededIfSpecifiedByParam) {
- // Specify by the parameter that signin is required.
- params_manager_.SetVariationParamsWithFeatureAssociations(
- ntp_snippets::kStudyName, {{"fetching_requires_signin", "true"}},
- {ntp_snippets::kArticleSuggestionsFeature.name});
-
- auto service = MakeService();
-
- // The default test setup is signed out.
- EXPECT_EQ(RemoteSuggestionsStatus::SIGNED_OUT_AND_DISABLED,
- service->GetStatusFromDeps());
-
- // Once signed in, we should be in a compatible state.
- utils_.fake_signin_manager()->SignIn("foo@bar.com");
- EXPECT_EQ(RemoteSuggestionsStatus::ENABLED_AND_SIGNED_IN,
- service->GetStatusFromDeps());
-}
-
TEST_F(RemoteSuggestionsStatusServiceTest, NoSigninNeeded) {
auto service = MakeService();
« no previous file with comments | « components/ntp_snippets/remote/remote_suggestions_status_service.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698