[Remote suggestions] Clean up variation params in the status service

components/ntp_snippets/remote/remote_suggestions_provider_impl_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/ntp_snippets/remote/remote_suggestions_provider_impl.h"
 
 #include <memory>
 #include <utility>
 #include <vector>
 
@@ skipping 1510 matching lines @@
 
   // The same article from the AOL domain should now be detected as dismissed.
   LoadFromJSONString(service.get(),
                      GetTestJson({GetSuggestionWithUrlAndTimesAndSource(
                          source_urls, source_urls[1], creation, expiry,
                          publishers[1], amp_urls[1])}));
   EXPECT_THAT(service->GetSuggestionsForTesting(articles_category()),
               IsEmpty());
 }
 
-TEST_F(RemoteSuggestionsProviderImplTest, StatusChanges) {
-  auto service = MakeSuggestionsProvider();
-
-  // Simulate user signed out
-  SetUpFetchResponse(GetTestJson({GetSuggestion()}));
-  service->OnStatusChanged(RemoteSuggestionsStatus::ENABLED_AND_SIGNED_IN,
-                           RemoteSuggestionsStatus::SIGNED_OUT_AND_DISABLED);
-
-  base::RunLoop().RunUntilIdle();
-  EXPECT_THAT(observer().StatusForCategory(articles_category()),
-              Eq(CategoryStatus::SIGNED_OUT));
-  EXPECT_THAT(RemoteSuggestionsProviderImpl::State::DISABLED,
-              Eq(service->state_));
-  EXPECT_THAT(service->GetSuggestionsForTesting(articles_category()),
-              IsEmpty());  // No fetch should be made.
-
-  // Simulate user sign in. The service should be ready again and load
-  // suggestions.
-  SetUpFetchResponse(GetTestJson({GetSuggestion()}));
-  service->OnStatusChanged(RemoteSuggestionsStatus::SIGNED_OUT_AND_DISABLED,
-                           RemoteSuggestionsStatus::ENABLED_AND_SIGNED_IN);
-  EXPECT_THAT(observer().StatusForCategory(articles_category()),
-              Eq(CategoryStatus::AVAILABLE_LOADING));
-
-  base::RunLoop().RunUntilIdle();
-  EXPECT_THAT(observer().StatusForCategory(articles_category()),
-              Eq(CategoryStatus::AVAILABLE));
-  EXPECT_THAT(RemoteSuggestionsProviderImpl::State::READY, Eq(service->state_));
-  EXPECT_FALSE(service->GetSuggestionsForTesting(articles_category()).empty());
-}
-
 TEST_F(RemoteSuggestionsProviderImplTest, ImageReturnedWithTheSameId) {
   auto service = MakeSuggestionsProvider();
 
   LoadFromJSONString(service.get(), GetTestJson({GetSuggestion()}));
 
   gfx::Image image;
   MockFunction<void(const gfx::Image&)> image_fetched;
   ServeImageCallback cb =
       base::Bind(&ServeOneByOneImage, &service->GetImageFetcherForTesting());
   {
@@ skipping 279 matching lines @@
                          RemoteSuggestionsProvider::ProviderStatus)>::Call,
                      base::Unretained(&status_callback))));
 
   // Should be called when becoming disabled.
   EXPECT_CALL(status_callback,
               Call(RemoteSuggestionsProvider::ProviderStatus::INACTIVE));
   service->EnterState(RemoteSuggestionsProviderImpl::State::DISABLED);
 }
 
 }  // namespace ntp_snippets