Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Unified Diff: components/ntp_snippets/remote/remote_suggestions_status_service.cc

Issue 2667623002: [Remote suggestions] Clean up variation params in the status service (Closed)
Patch Set: Rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets/remote/remote_suggestions_status_service.cc
diff --git a/components/ntp_snippets/remote/remote_suggestions_status_service.cc b/components/ntp_snippets/remote/remote_suggestions_status_service.cc
index 315cf13b69139c74025cb55f352c9a780dddeac3..525dbbdbc1afe2a26edf7c96ceff9f007e2ad395 100644
--- a/components/ntp_snippets/remote/remote_suggestions_status_service.cc
+++ b/components/ntp_snippets/remote/remote_suggestions_status_service.cc
@@ -15,31 +15,12 @@
namespace ntp_snippets {
-namespace {
-
-const char kFetchingRequiresSignin[] = "fetching_requires_signin";
-const char kFetchingRequiresSigninEnabled[] = "true";
-const char kFetchingRequiresSigninDisabled[] = "false";
-
-} // namespace
-
RemoteSuggestionsStatusService::RemoteSuggestionsStatusService(
SigninManagerBase* signin_manager,
PrefService* pref_service)
: status_(RemoteSuggestionsStatus::EXPLICITLY_DISABLED),
- require_signin_(false),
signin_manager_(signin_manager),
- pref_service_(pref_service) {
- std::string param_value_str = variations::GetVariationParamValueByFeature(
- kArticleSuggestionsFeature, kFetchingRequiresSignin);
- if (param_value_str == kFetchingRequiresSigninEnabled) {
- require_signin_ = true;
- } else if (!param_value_str.empty() &&
- param_value_str != kFetchingRequiresSigninDisabled) {
- DLOG(WARNING) << "Unknow value for the variations parameter "
- << kFetchingRequiresSignin << ": " << param_value_str;
- }
-}
+ pref_service_(pref_service) {}
RemoteSuggestionsStatusService::~RemoteSuggestionsStatusService() = default;
@@ -99,11 +80,6 @@ RemoteSuggestionsStatus RemoteSuggestionsStatusService::GetStatusFromDeps()
return RemoteSuggestionsStatus::EXPLICITLY_DISABLED;
}
- if (require_signin_ && !IsSignedIn()) {
- DVLOG(1) << "[GetStatusFromDeps] Signed out and disabled due to this.";
- return RemoteSuggestionsStatus::SIGNED_OUT_AND_DISABLED;
- }
-
DVLOG(1) << "[GetStatusFromDeps] Enabled, signed "
<< (IsSignedIn() ? "in" : "out");
return IsSignedIn() ? RemoteSuggestionsStatus::ENABLED_AND_SIGNED_IN

Powered by Google App Engine
This is Rietveld 408576698